Details
-
Bug
-
Resolution: Unresolved
-
Major
-
None
-
15.10.5
-
Unknown
-
Awaiting Committer feedback
-
Description
Note: the affect version needs to be refined
Reproduction steps
- Go to http://localhost:8080/xwiki/bin/view/Tour/
- Edit all listed tours and uncheck "activate"
- Go to any page with the browser debug tool opened
- Check the network tab
Expected
No "tour" related http requests can be found
Actual
The following requests are made:
- http://localhost:8080/xwiki/bin/jsx/TourCode/TourJS?language=en&docVersion=1.1
- http://localhost:8080/xwiki/bin/get/TourCode/TourJson?xpage=plain&outputSyntax=plain&tourDoc=Main.WebHome
Also, if all the tours are loaded for a given user, there is no need to load them again.
Possible approaches:
- very fine-grained and only load the js for a given page if at least one tour or one step of a tour targets the current page with the right action etc...
- load the js everywhere as long as at least one tour is activated (not so great but a least the tour won't be loaded when it's strictly useless)