Uploaded image for project: 'XWiki Commons'
  1. XWiki Commons
  2. XCOMMONS-3847

Invalid boolean and number values of a bean property are silently converted instead of failing

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 17.10.14, 18.8.0
    • Properties
    • None
    • Unknown

    Description

      A macro parameter of type boolean or int accepts any value. A value that does not convert is replaced without an error: an unknown boolean becomes false and an invalid number becomes 0. The macro then runs with a value the user never typed, and nothing tells them the value was wrong.

      Steps to reproduce

      1. Edit a page with the wiki editor.
      2. Add {{toc numbered="maybe"/}} and {{toc depth="abc"/}} on a page with headings.
      3. Save and view the page.

      Expected

      Both macros fail with a message saying that the value of the parameter cannot be converted.

      Actual

      • The first table of contents renders unnumbered, as if numbered was false.
      • The second fails with "Failed to validate bean: [must be greater than or equal to 1]": abc was converted to 0, and only the @Min(1) constraint stopped it.

      The WYSIWYG usability audit of the macros found the same on most of the 67 macros reviewed, for example wiki="abc" on the HTML macro, status="maybe" on the message macros, readOnly="maybe" on documentTree, which makes the tree editable, and count="abc" on notifications, which loops forever, see XWIKI-25412.

      Lead

      ConvertUtilsConverter registers the throwing BeanUtils converters in initialize(), on BeanUtilsBean.getInstance(), so that a failed conversion raises an error rather than returning a default value. That instance is kept per context class loader, so the conversions run under another context class loader may use the lenient default converters. The tests of ConvertUtilsConverter do not cover an invalid boolean or number.

      Attachments

        Issue Links

          blocks

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25578 Report a missing or unknown target in the errors of the include, display, context, uiextensions and wikimacroparameter macros

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25579 Report a missing or invalid jar in the errors of the script macros

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25580 Report the invalid values of the documents, documentTree and tree macros instead of an empty result

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25581 Report the invalid values of the attachmentGalleryPicker and attachmentSelector macros instead of showing nothing

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25582 Refuse the invalid values of the cache, code, container, gallery and menu macros instead of ignoring them

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25583 Report a missing user or icon in the displayIcon, mention and useravatar macros instead of falling back silently

          • Major - Major loss of function.
          • Open
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. XRENDERING-828 Provide an image picker for the image parameter of the box and message macros

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25457 Provide a field for CSS values in the Edit Macro dialog

          • Major - Major loss of function.
          • Open
          relates to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-25412 The notifications loop forever when the requested count is 0 or not a number

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. XRENDERING-823 The error shown for an invalid macro parameter doesn't name the parameter or the expected value

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25182 Numeric macro parameters accept any text in the Edit Macro dialog

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25197 Allow wiki macro parameters to declare a range or a format for their value

          • Major - Major loss of function.
          • Open

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-25287 The Edit Macro dialog doesn't enforce the constraints declared on the parameters of Java macros

          • Major - Major loss of function.
          • Open

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: