Provide an image picker for the image parameter of the box and message macros

The image parameter of the box and message macros is a plain text field in the Edit Macro dialog, so the user has to type the reference of an image they cannot browse for, and a reference to an attachment that does not exist is accepted silently.

The macros to change, with the file where most of the fix is done:

• box, info, warning, error and success: parameters declared in BoxMacroParameters.java, shared by the five macros.

The main problems:

• The parameter is typed as a resource reference, but declares no display type, so the dialog gives it no picker: the user can neither browse the attachments of the page nor upload an image.
• A reference to a missing attachment is accepted by the dialog and, once rendered, gives a broken image with no message, so the user does not know that the reference is wrong.

The office macro already gives a resource reference parameter an attachment picker, through a display type declared in OfficeMacroParameters.java and its edit displayer, which keeps the upload and restricts the files to the expected types. The same could be done for images.

KOs covered

Impact found on macro fluidity

These 10 KOs come from the WYSIWYG usability audit of the macros, under the criteria C4 input-assistance and E2 errors of its usability criteria. The page of each macro, linked in the table, has the full notes and the steps to reproduce. Fixing them means changing the declaration of the image parameter in the macro definitions: a picker only offers existing images, so it also stops invalid values from being provided.

The E2 errors KOs are only partly covered here, for the image. The same KOs also report the other invalid values accepted silently, covered elsewhere: the width by XRENDERING-826, the status by XCOMMONS-3847, and the wording of the error by XRENDERING-823.