Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-10186

Duplicated root namespace extension in DW "Extensions" step

Details

    • Unknown
    • N/A
    • N/A

    Description

      Looks like when an extension to upgrade is installed on root namespace the "Extension" DW step also think it's installed on main wiki.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. XCOMMONS-557 Root extension listed in upgrade plan calculated for a namespace

          • Major - Major loss of function.
          • Closed

          Activity

            [XWIKI-10186] Duplicated root namespace extension in DW "Extensions" step
            tmortagne Thomas Mortagne added a comment -

            The duplicate is caused by XCOMMONS-557.

            tmortagne Thomas Mortagne added a comment - The duplicate is caused by XCOMMONS-557 .
            tmortagne Thomas Mortagne added a comment -

            I just tested in a unit tets and other namespaces have the exact same issue actually, I guess the UI is simply hiding it in subwikis.

            tmortagne Thomas Mortagne added a comment - I just tested in a unit tets and other namespaces have the exact same issue actually, I guess the UI is simply hiding it in subwikis.
            tmortagne Thomas Mortagne added a comment -

            Hmm that does not make much sense, from EM point there is nothing special about "wiki:xwiki" namespace so it should work exactly the same way. Lets try to reproduce.

            tmortagne Thomas Mortagne added a comment - Hmm that does not make much sense, from EM point there is nothing special about "wiki:xwiki" namespace so it should work exactly the same way. Lets try to reproduce.
            mflorea Marius Dumitru Florea added a comment -

            tmortagne, this happens when the upgrade plan is computed for the main wiki. The upgrade plan tree contains in this case on the first level the same extension twice, once for the global namespace and once for the main wiki?

            #set ($plan = $services.extension.getExtensionPlanJobStatus($null, 'wiki:xwiki'))
#foreach ($firstLevelNode in $plan.tree)
  #set ($planAction = $firstLevelNode.action)
  * $planAction.extension , $planAction.namespace
#end

            produces:

            org.xwiki.rendering:xwiki-rendering-macro-jira-5.4.3 , wiki:xwiki
org.xwiki.rendering:xwiki-rendering-macro-jira-5.4.3 , $planAction.namespace

            You can reproduce this by installing org.xwiki.rendering:xwiki-rendering-macro-jira-5.3 on 6.0-SNAPSHOT and then going to Extension Updater section in the main wiki administration.

            If I compute the upgrade plan for the global namespace or for a sub wiki the result is good. A quick fix is to compute the upgrade plan for the global namespace when on the main wiki but this is a problem for large farms like myxwiki.org where you want to compute the upgrade plan only for the main wiki, not for the entire farm (which it going to take a while..).

            So there are two issues to fix:

            1. global extensions are duplicated when computing the upgrade plan for the main wiki (works fine for the global namespace and subwikis)
            2. there's no way for the user to choose between computing the upgrade plan only for the main wiki (myxwiki.org) and computing the upgrade plan for the entire farm (xwiki.org) (I'm referring to the Extension Updater here).
            mflorea Marius Dumitru Florea added a comment - tmortagne , this happens when the upgrade plan is computed for the main wiki. The upgrade plan tree contains in this case on the first level the same extension twice, once for the global namespace and once for the main wiki? #set ($plan = $services.extension.getExtensionPlanJobStatus($null, 'wiki:xwiki')) #foreach ($firstLevelNode in $plan.tree) #set ($planAction = $firstLevelNode.action) * $planAction.extension , $planAction.namespace #end produces: org.xwiki.rendering:xwiki-rendering-macro-jira-5.4.3 , wiki:xwiki org.xwiki.rendering:xwiki-rendering-macro-jira-5.4.3 , $planAction.namespace You can reproduce this by installing org.xwiki.rendering:xwiki-rendering-macro-jira-5.3 on 6.0-SNAPSHOT and then going to Extension Updater section in the main wiki administration. If I compute the upgrade plan for the global namespace or for a sub wiki the result is good. A quick fix is to compute the upgrade plan for the global namespace when on the main wiki but this is a problem for large farms like myxwiki.org where you want to compute the upgrade plan only for the main wiki, not for the entire farm (which it going to take a while..). So there are two issues to fix: global extensions are duplicated when computing the upgrade plan for the main wiki (works fine for the global namespace and subwikis) there's no way for the user to choose between computing the upgrade plan only for the main wiki (myxwiki.org) and computing the upgrade plan for the entire farm (xwiki.org) (I'm referring to the Extension Updater here).

            People

              mflorea Marius Dumitru Florea
              tmortagne Thomas Mortagne
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: