Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-10608

Share page by email doesn't work because IP version testing

    Details

    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Pull Request Status:
      Awaiting Committer feedback
    • Similar issues:

      Description

      Hello,

      Because of the regexp IP version testing in shareinline.vm, "xwiki.getXWikiPreference('admin_email')" is not used but noreply@domain.net or noreply@$!{serverName} (even if 'admin_email' is filled)

      I propose to invert the test like this:
      is there a valid admin_email configured?
      ├ yes: use the admin_email
      └ no :is the server name an IP?
      _ └ yes: use a generic nodomain.net
      _ └ no: use the actual domain name

        Attachments

          Activity

            People

            • Assignee:
              Pbas Pascal BASTIEN
              Reporter:
              Pbas Pascal BASTIEN
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: