XWiki Platform
  1. XWiki Platform
  2. XWIKI-10774

The LESS compiler always uses skins & color themes of the main wiki

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 6.1
    • Fix Version/s: 6.2-milestone-2
    • Component/s: LESS
    • Labels:
      None
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      The LESS compiler takes into account the current skin and the current color theme to compute CSS files.

      But it does not use the skin & the color themes of the subwiki when it is called from a there.

      As a result, Flamingo fails on subwikis.

        Activity

        Hide
        Ecaterina Moraru (Valica) added a comment -

        What do you mean in fails on subwikis? Also consider that Colibri is still the Base skin.

        Show
        Ecaterina Moraru (Valica) added a comment - What do you mean in fails on subwikis? Also consider that Colibri is still the Base skin.
        Hide
        Guillaume Delhumeau added a comment -

        Ecaterina Moraru (Valica): On my snapshot, when I have put "flamingo" as the base skin of "XWiki.DefaultSkin", the LESS compiler printed an error et the CSS were broken. It has nothing to do with the Base skin on the webapp. The problem was: if on a subwiki, I set "ColorTheme.DefaultColorTheme" as the color theme, the LESS compiler understand "xwiki:ColorTheme.DefaultColorTheme" instead of "subwiki:ColorTheme.DefaultColorTheme". Same for the skin. And for some reasons, it made the LESS compiler fail.

        Show
        Guillaume Delhumeau added a comment - Ecaterina Moraru (Valica) : On my snapshot, when I have put "flamingo" as the base skin of "XWiki.DefaultSkin", the LESS compiler printed an error et the CSS were broken. It has nothing to do with the Base skin on the webapp. The problem was: if on a subwiki, I set "ColorTheme.DefaultColorTheme" as the color theme, the LESS compiler understand "xwiki:ColorTheme.DefaultColorTheme" instead of "subwiki:ColorTheme.DefaultColorTheme". Same for the skin. And for some reasons, it made the LESS compiler fail.

          People

          • Assignee:
            Guillaume Delhumeau
            Reporter:
            Guillaume Delhumeau
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Date of First Response: