Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-11112

Adding a rendering cache to the Icon Theme Application

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 6.2
    • Fix Version/s: None
    • Component/s: Icon Themes
    • Labels:
    • Difficulty:
      Easy
    • Similar issues:

      Description

      Currently, in the icon theme implementation, we cache the mapping between icon names and values, in order to not load the Icon Theme document every time.

      icon-name : name-of-the-corresponding-icon-in-the-icon-theme
      

      Then, we use DefaultIconRenderer that executes the Velocity interpretor to compute the output code that display the icon. And we use this for every icon we render in a page.

      name-of-the-corresponding-icon-in-the-icon-theme -> <span class="fa fa-name-of-the-corresponding-icon-in-the-icon-theme"></span>
      

      This last step can take time (how much? should we do a benchmark?), so I propose to have a cache component for the rendering code corresponding to the icon.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              gdelhumeau Guillaume Delhumeau
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Date of First Response: