Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-12873

Mail sender plugin may use the wrong Velocity context

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: 6.4.6
    • Fix Version/s: 7.4-milestone-2, 7.1.4, 6.4.7
    • Component/s: Mail
    • Labels:
      None
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      It's getting it from XWikiContext without checking if there is actually one while proper VelocityContext should come from VelocityManager which make sure you get one and also that it's in sync with ScriptContext.

      This makes impossible to use velocity tools in a mail template executed from some background thread which most of the time don't really care about Velocity itself and often have a XWikiContext with no VelocityContext at all in it.

        Attachments

          Activity

            People

            • Assignee:
              tmortagne Thomas Mortagne
              Reporter:
              tmortagne Thomas Mortagne
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: