XWiki Platform
  1. XWiki Platform
  2. XWIKI-13372

Failed to upgrade XWiki.TemplateProviderTemplate between pre-NS and post-NS version

    Details

    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      During a migration from XWiki 6.2.4 to 7.4.2, I go the following NPE when proceeding to the upgrade of XWiki.TemplateProviderTemplate:

      Failed to install document [Main wiki » XWiki » TemplateProviderTemplate]
      class java.lang.NullPointerException: null
          at com.xpn.xwiki.objects.BaseProperty.equals(BaseProperty.java:96)
          at com.xpn.xwiki.objects.BaseStringProperty.equals(BaseStringProperty.java:57)
          at com.xpn.xwiki.objects.BaseCollection.equals(BaseCollection.java:614)
          at com.xpn.xwiki.objects.BaseObject.equals(BaseObject.java:235)
          at com.xpn.xwiki.doc.XWikiDocument.equalsData(XWikiDocument.java:4195)
          at org.xwiki.extension.xar.internal.handler.packager.DocumentMergeImporter.saveDocument(DocumentMergeImporter.java:99)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importDocumentToWiki(Packager.java:223)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importXARToWiki(Packager.java:174)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importXARToWiki(Packager.java:146)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importXAR(Packager.java:136)
          at org.xwiki.extension.xar.internal.handler.XarExtensionHandler.installInternal(XarExtensionHandler.java:203)
          at org.xwiki.extension.xar.internal.handler.XarExtensionHandler.upgrade(XarExtensionHandler.java:186)
          at org.xwiki.extension.handler.internal.DefaultExtensionHandlerManager.upgrade(DefaultExtensionHandlerManager.java:138)
          at org.xwiki.extension.job.internal.AbstractExtensionJob.installExtension(AbstractExtensionJob.java:263)
          at org.xwiki.extension.job.internal.AbstractExtensionJob.applyAction(AbstractExtensionJob.java:204)
          at org.xwiki.extension.job.internal.AbstractExtensionJob.applyActions(AbstractExtensionJob.java:151)
          at org.xwiki.extension.job.internal.InstallJob.runInternal(InstallJob.java:150)
          at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:205)
          at org.xwiki.job.AbstractJob.run(AbstractJob.java:188)
          at org.xwiki.extension.job.history.internal.ReplayJob.replay(ReplayJob.java:121)
          at org.xwiki.extension.job.history.internal.ReplayJob.runInternal(ReplayJob.java:109)
          at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:205)
          at org.xwiki.job.AbstractJob.run(AbstractJob.java:188)
          at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
          at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
          at java.lang.Thread.run(Thread.java:745)
      

      The peculiarity of this document between pre-NS and post-NS is that is contains an objet of a class that have been changed (removed one props and added another one), and that have been migrated using a database migration.

        Activity

        Hide
        Thomas Mortagne added a comment - - edited

        Looks like the issue is just that BaseObject.equals does not expect ending up comparing object which don't have the same properties set. We were just lucky that upgrade usually add new properties and rarely remove properties I guess.

        Show
        Thomas Mortagne added a comment - - edited Looks like the issue is just that BaseObject.equals does not expect ending up comparing object which don't have the same properties set. We were just lucky that upgrade usually add new properties and rarely remove properties I guess.

          People

          • Assignee:
            Thomas Mortagne
            Reporter:
            Denis Gervalle
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Date of First Response: