Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-15971

Have annotation values override system properties in Docker-based tests

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 10.10
    • Fix Version/s: 10.11-rc-1
    • Component/s: Test Framework
    • Labels:
      None
    • Difficulty:
      Unknown
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      The current Docker test framework allows to define the Servlet Engine or the Browser to use in two different ways:
      1. by specifying it in the annotation @UITest
      2. by giving it in the command line using this kind of argument: -Dxwiki.test.ui.servletEngine=tomcat

      However, currently, the annotation value has always the priority over the given parameter. Then the only way to allow passing a value in the command line, is by not setting the value in UITest.

      It ultimately means that we cannot change the default value of the Servlet Engine for the test AND to allow using another version by command line.
      In order to fix that I propose that the command line parameter value to have always the priority over the UITest parameter value.

        Attachments

          Activity

            People

            • Assignee:
              surli Simon Urli
              Reporter:
              surli Simon Urli
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: