Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-17796

Use ComponentManager to set the XMLReader used by PDF export

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 12.7.1
    • Fix Version/s: None
    • Component/s: Old Core - PDF export
    • Labels:
      None
    • Difficulty:
      Easy
    • Pull Request Status:
      Awaiting Committer feedback
    • Similar issues:

      Description

      Currently, PDF export uses the XMLReader instance created internally by dom4j's SAXReader. As that default XMLReader is configured to remove the entities, the export process has to reset that configuration (and there is little hope that dom4j is going to provide a solution anytime soon).

      Instead, I suggest using a XWiki's own XMLReader as delivered by ComponentManager. This has the advantage of not depending on dom4j's decisions, and using the standardized facility that XWiki has for this. I'm preparing a pull request.

      Depends on XCOMMONS-2026.

        Attachments

          Activity

            People

            • Assignee:
              carlosame Carlos Amengual
              Reporter:
              carlosame Carlos Amengual
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated: