Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-18144

Uninstalling an extension app may not delete the home page

Details

    • Bug
    • Resolution: Invalid
    • Major
    • None
    • 12.9
    • Extension
    • None
    • Unknown
    • N/A
    • N/A

    Description

      For ex, uninstall the Help Center app. You'll see:

      The job logs contains:

      Deleted document [Home » Help » Macros » Gallery » WebHome]
Deleted document [Home » Help » Applications » Movies » Code » WebHome]
Deleted document [Home » Help » Applications » Contributors » WebHome]
Deleted document [Home » Help » Videos » WebHome]
Deleted document [Home » Help » Applications » Contributors » Code » ContributorsTemplateProvider]
Deleted document [Home » Help » Applications » Contributors » Code » ContributorsClass]
Deleted document [Home » Help » Macros » Notifications » Preview » WebHome]
Deleted document [Home » Help » Applications » Movies » WebHome]
Deleted document [Home » Help » Macros » Notifications » WebHome]
Deleted document [Home » Help » Macros » Chart » Preview » WebHome]
Deleted document [Home » Help » Applications » Movies » Modern Times]
Deleted document [Home » Help » Applications » Contributors » Charlie Chaplin]
Deleted document [Home » Help » Macros » Box » Preview » WebHome]
Deleted document [Home » Help » Applications » Contributors » Code » ContributorsTranslations]
Deleted document [Home » Help » Macros » Chart » WebHome]
Deleted document [Home » Help » Code » Translations]
Deleted document [Home » Help » Applications » Movies » Code » MoviesTemplate]
Deleted document [Home » Help » Macros » ToC » Preview » WebHome]
Deleted document [Home » Help » Macros » Tree » Preview » WebHome]
Deleted document [Home » Help » Applications » Movies » Code » MoviesTranslations]
Deleted document [Home » Help » Applications » Contributors » Code » ContributorsSheet]
Deleted document [Home » Help » Applications » Contributors » Frank Capra]
Deleted document [Home » Help » Macros » WebHome]
Deleted document [Home » Help » Code » Translations]
Deleted document [Home » Help » Macros » ToC » WebHome]
Deleted document [Home » Help » Code » Translations]
Deleted document [Home » Help » Code » ExampleMacro]
Deleted document [Home » Help » Code » Translations]
Deleted document [Home » Help » Applications » Contributors » WebPreferences]
Deleted document [Home » Help » Macros » Box » WebHome]
Deleted document [Home » Help » Applications » Contributors » Code » ContributorsTemplate]
Deleted document [Home » Help » Applications » Movies » Code » MoviesClass]
Deleted document [Home » Help » Code » VelocityMacros]
Deleted document [Home » Help » Applications » Contributors » Code » WebHome]
Deleted document [Home » Help » Applications » Movies » Code » MoviesTemplateProvider]
Deleted document [Home » Help » Applications » Movies » Code » MoviesSheet]
Deleted document [Home » Help » Macros » Tree » WebHome]
Deleted document [Home » Help » Macros » Gallery » Preview » WebHome]
Deleted document [Home » Help » Code » Translations]
Deleted document [Home » Help » Applications » Movies » WebPreferences]
Deleted document [Home » Help » Applications » Movies » Meet John Doe]
Deleted document [Home » Help » Templates » WebHome]
Deleted document [Home » Help » Applications » WebHome]

      which shows that Help.WebHome is not removed. This is proved by the fact that the Help entry is still displayed in the App panel:

      And ofc, it's broken when clicked:

      Attachments

        Issue Links

          is related to

          Task - A task that needs to be done. XWIKI-18147 Merge the Help Center Application into the Platform Help Application

          • Major - Major loss of function.
          • Closed

          Improvement - An improvement or enhancement to an existing feature or task. XWIKI-18148 Uninstalling a XAR extension that has common pages with another extension should list the common pages

          • Major - Major loss of function.
          • Open

          Activity

            [XWIKI-18144] Uninstalling an extension app may not delete the home page
            vmassol Vincent Massol added a comment -

            I'm closing this one since I've now created 2 more specific issues:

            vmassol Vincent Massol added a comment - I'm closing this one since I've now created 2 more specific issues: XWIKI-18147 XWIKI-18148
            vmassol Vincent Massol added a comment -

            Indeed I think you're right. So there are several issues to fix:
            1) The two apps shouldn't share the same home page, especially since they don't have the same content for it. The only reason it works right now is because the Help center App is declared after the Help app in the XS flavor poms and thus the Help center's home page overwrites the Help app one.
            2) IMO the EM should still list the common page and untick it by default, with a message explaining why (because it belongs to that other extension).

            To fix 1), I feel it could be time and good to merge the two apps and to move the Help Center app into xwiki-platform. I've never been fond of including contrib apps in XS so I'd be in favor of moving it to platform. We've seen over the years that the Help Center app doesn't change much and I don't think it's needed to have it outside of platform. I'm going to send a vote for that.

            vmassol Vincent Massol added a comment - Indeed I think you're right. So there are several issues to fix: 1) The two apps shouldn't share the same home page, especially since they don't have the same content for it. The only reason it works right now is because the Help center App is declared after the Help app in the XS flavor poms and thus the Help center's home page overwrites the Help app one. 2) IMO the EM should still list the common page and untick it by default, with a message explaining why (because it belongs to that other extension). To fix 1), I feel it could be time and good to merge the two apps and to move the Help Center app into xwiki-platform. I've never been fond of including contrib apps in XS so I'd be in favor of moving it to platform. We've seen over the years that the Help Center app doesn't change much and I don't think it's needed to have it outside of platform. I'm going to send a vote for that.
            mflorea Marius Dumitru Florea added a comment - - edited

            Isn't this because the Help Center Application (from xwiki-contrib) shares the same home page with the Help Application (from platform)? So the extension manager keeps the home page after uninstalling the Help Center because it's still part of the Help application.

            mflorea Marius Dumitru Florea added a comment - - edited Isn't this because the Help Center Application (from xwiki-contrib) shares the same home page with the Help Application (from platform)? So the extension manager keeps the home page after uninstalling the Help Center because it's still part of the Help application.

            People

              vmassol Vincent Massol
              vmassol Vincent Massol
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: