Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-18260

Improve automated tests for creating a template provider

    XMLWordPrintable

Details

    • Unknown

    Description

      There are some differences between manual test https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Create%20a%20New%20Template%20Provider and the automated test from https://github.com/xwiki/xwiki-platform/blob/0e3ec41cda7ac82f14e8cc092ff2e5f059ed1fc1/xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-docker/src/test/it/org/xwiki/administration/test/ui/PageTemplatesIT.java#L70 as the manual test also checks the presence of icon and location pickers when creating the template and if the created template is displayed under 'Type' section only in selected location where it must be available.

      The matrix discussion:

      https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$16112316371074vjXar:matrix.xwiki.com?via=matrix.org&via=matrix.xwiki.com&via=t2bot.io:

      "Ilie Andriuta: Hi! Continuing the manual tests migration, this week there is one test about creating of a new Template Provider using restrictions:
      https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Create%20a%20New%20Template%20Provider
      I've checked https://github.com/xwiki/xwiki-platform/blob/0e3ec41cda7ac82f14e8cc092ff2e5f059ed1fc1/xwiki-platform-core/xwiki-platform->administration/xwiki-platform-administration-test/xwiki-platform-administration-test->docker/src/test/it/org/xwiki/administration/test/ui/PageTemplatesIT.java#L70 but from what I could see, there are some differences on the Expected >Results on the manual test which seem don't seem to be covered by the automated tests (like testing the presence of icon and location pickers when creating the template and if the created template is displayed under 'Type' section only in selected location where it must be available).
      Can you please confirm the missing differences on the automated tests? So that I can create a JIRA task for improving it.

      Vincent Massol: Indeed, I've read the test you pointed and it doesn't set the icon and location. Note that your manual test is also missing a check: to verify that the template is NOT proposed outside of the location restriction. Yes you can go ahead and create the jira.

      Do you have only a single tests related to templates in the manual tests? I think it would be better to analyse all tests in a given area, since you/we need to read the automated tests so we have an idea of what it does and we can compare against all the manual tests for that domain. WDYT?

      I see several at https://test.xwiki.org/xwiki/bin/view/Main/#|t=qa&p=1&l=15&s=doc.title&d=asc&doc.title=Template
      for ex https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Create%20Page%20From%20Template

      Ilie Andriuta: yes, that's I was searching right now

      Vincent Massol: (already automated for that one )
      Ilie Andriutahttps://test.xwiki.org/xwiki/bin/view/Main/#|t=qa&p=1&l=15&s=doc.title&d=asc&doc.title=template
      > (already automated for that one )
      already marked as automated on 18.12.2020
      ok, I will analyze all templates related tests until finishing them
      I agree it's better to analyze a certain area, yes
      Vincent Massol: Note that your manual test is also missing a check: to verify that the template is NOT proposed outside of the location restriction.
      Ilie Andriuta: actually it checks for that at the 4th expected result:
      The template can be found under "Type" only in the selected location (in this case Sandbox)"

      Attachments

        Activity

          People

            Unassigned Unassigned
            iandriuta Ilie Andriuta
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: