Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-19318

Resolving null with DocumentDocumentReferenceUserReferenceResolver should return GuestUserReference

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 14.0-rc-1, 13.10.3
    • 12.10.10
    • User
    • None
    • Unit
    • Unknown
    • N/A
    • N/A

    Description

      Right now resolving null with DocumentDocumentReferenceUserReferenceResolver returns CurrentUserReference, however it doesn't really makes sense here since historically in XWiki when a DocumentReference corresponding to a user is set to null it corresponds to Guest. We even have some checkers that we use properly null for a guest user, and not XWikiGuest.
      So returning a CurrentUserReference is counter productive for this resolver: it means that any consumer of the API would have to call the resolver, then check if it's CurrentUserReference and then call a second resolver to obtain guest.

      Attachments

        Issue Links

          Activity

            People

              surli Simon Urli
              surli Simon Urli
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: