Details
-
Task
-
Resolution: Unresolved
-
Major
-
None
-
11.10.13
-
Unknown
-
Description
The manual test is here: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Change%20the%20Icon%20Theme%20from%20Administer%20Page
The test verifies that changing the Icon Theme from Page Administration is working properly.
Matrix discussion: https://matrix.to/#/!ikPtGZaGWtyblizzlR:matrix.xwiki.com/$1646915978767Tffzh:matrix.xwiki.com?via=matrix.org&via=matrix.xwiki.com&via=caubin.fr
Ilie Andriuta: Hi! Continuing the manual tests migration, there is a test about checking if changing the Icon Theme from Page Administration is displaying properly: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Change%20the%20Icon%20Theme%20from%20Administer%20Page
I've checked https://github.com/xwiki/xwiki-platform/blob/60ed72d56eb22e24243428a0455cccbed8dbb406/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-page/src/main/java/org/xwiki/test/page/IconSetup.java and https://github.com/xwiki/xwiki-platform/blob/fcb86c7dbed7488512688fdb3f47dc9a40745b48/xwiki-platform-core/xwiki-platform-icon/xwiki-platform-icon-test/xwiki-platform-icon-test-docker/src/test/it/org/xwiki/icon/test/ui/IconThemesRestIT.java but couldn't find automated tests for it.
Can you please confirm whether the automated test exists for it or not and maybe providing the link to it?Thanks!
Vincent Massol: checking
Note: one good way to check this too Ilie Andriuta is to look for a PageObject class for the UI in question
in this case I guess if we had a PO for it, it would extend AdministrationSectionPage
we have ThemesAdministrationSectionPage
but it seems to only contain ColorThemes APIs
https://github.com/xwiki/xwiki-platform/blob/6668147f1178bde83232fc931b3b517b70ba6567/xwiki-platform-core/xwiki-platform-administration/xwiki-platform-administration-test/xwiki-platform-administration-test-pageobjects/src/main/java/org/xwiki/administration/test/po/ThemesAdministrationSectionPage.java#L37
so it's missing some get/setIconTheme() APIs
which seems to indicate that we don't have any UI tests to validate the usage of the UI for setting an Icon Theme
Ilie Andriuta: I see, thanks, I will create a task for it