Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 11.1-rc-1
-
Fix Version/s: 14.6-rc-1
-
Component/s: Refactoring
-
Labels:
-
Difficulty:Unknown
-
Documentation:N/A
-
Documentation in Release Notes:N/A
-
Pull Request Status:Awaiting Committer feedback
-
Similar issues:
Description
Regression introduced in XWIKI-6732
In AbstractCopyOrMoveJob#copyOrMove():
...1st time... if (!this.atomicOperation(oldReference, newReference)) { return false; } ...2nd time... this.observationManager.notify(afterEvent, this, this.getRequest()); ...
Notes:
- atomicOperation calls XWiki#renameDocument()
- and notify() will call RelativeLinkUpdateListener
- Both do the same thing, i.e. refactor the document content links
- Funnily if the old way (i.e. XWiki#renameDocument()) fails then the new way (i.e. RelativeLinkUpdateListener) isn't called
We need to fix this to perform the refactoring only once.
Attachments
Issue Links
- is caused by
-
XWIKI-6732 Introduce DocumentRenamingEvent and DocumentRenamedEvent events
-
- Closed
-
- is duplicated by
-
XWIKI-19526 Relative links to self typed as "doc" are not updated correctly on rename
-
- Closed
-