Details
-
Bug
-
Resolution: Invalid
-
Major
-
None
-
14.4, 14.5, 14.6, 14.7, 14.8, 14.9
-
None
-
Unknown
-
Description
On a brand new XWiki, versions 14.4 to 14.9 (I have not tested prior and later versions), when I click edit on the home page, triggering the inline editor, I see that the hidden input name=xaction between the "Save & View" and the "Save" buttons has a value="$escapetool.xml($action)".
Expected behavior
This input should have value "save".
Initial Investigation
This comes from the request http://localhost:8090/xwiki/bin/get/Main/?xpage=editactions triggered by the JSX at http://localhost:8090/xwiki/bin/jsx/XWiki/InplaceEditing?language=en&docVersion=1.1&minify=false
Likely produced by macro 'editActionButton', defined in these files:
- xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/macros.vm
- xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/macros.vm
its $action parameter is passed by variable at xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/editactions.vm:
31: #editActionButton($saveaction, 'saveandview', 'btn-primary')
It seems $saveaction is expected to be set but is not. It is defined to "save" at these locations:
xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/editwysiwyg.vm
34: #set ($saveaction = 'save')
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/editinline.vm
27:#set($saveaction = "save")
xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/editwiki.vm
24:#set($saveaction = "save")