Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-21252

Error when merging several @UITest defining xwikiPropertiesAdditionalProperties properties

    XMLWordPrintable

Details

    • Unit
    • Unknown
    • N/A
    • N/A

    Description

      Right now if you have:

      @UITest(properties = {
        "xwikiPropertiesAdditionalProperties=test.prchecker.excludePattern=.*:XWiki\\."
            + "(ResetPassword|ResetPasswordComplete)"
    })

@UITest(properties = {        "xwikiPropertiesAdditionalProperties=test.prchecker.excludePattern=.*:ConfigurableClassIT\\."
        + "(testCodeToExecutionAndAutoSandboxing.WebHome"
        + "|testLockingAndUnlocking.TestConfigurable1"
        + "|testLockingAndUnlocking.TestConfigurable2)"
})

      You get:

      xwikiPropertiesAdditionalProperties=test.prchecker.excludePattern=.*:XWiki\\.(ResetPassword|ResetPasswordComplete),test.prchecker.excludePattern=.*:ConfigurableClassIT\\.(testCodeToExecutionAndAutoSandboxing.WebHome|testLockingAndUnlocking.TestConfigurable1|testLockingAndUnlocking.TestConfigurable2)

      which leads to a xwiki.properties with a bad config:

      test.prchecker.excludePattern=.*:XWiki\\.(ResetPassword|ResetPasswordComplete),test.prchecker.excludePattern=.*:ConfigurableClassIT\\.(testCodeToExecutionAndAutoSandboxing.WebHome|testLockingAndUnlocking.TestConfigurable1|testLockingAndUnlocking.TestConfigurable2)

      And config.getProperty("xwikiPropertiesAdditionalProperties") will return an array with values:

      • .*:XWiki
        .(ResetPassword|ResetPasswordComplete)
      • test.prchecker.excludePattern=.*:ConfigurableClassIT
        .(testCodeToExecutionAndAutoSandboxing.WebHome|testLockingAndUnlocking.TestConfigurable1|testLockingAndUnlocking.TestConfigurable2)

      Instead we should have:

      xwikiPropertiesAdditionalProperties=test.prchecker.excludePattern=.*:XWiki\\.(ResetPassword|ResetPasswordComplete)\ntest.prchecker.excludePattern=.*:ConfigurableClassIT\\.(testCodeToExecutionAndAutoSandboxing.WebHome|testLockingAndUnlocking.TestConfigurable1|testLockingAndUnlocking.TestConfigurable2)

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-20497 The PR checker is not executed for docker-based tests

          • Major - Major loss of function.
          • Closed

          Activity

            People

              vmassol Vincent Massol
              vmassol Vincent Massol
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: