Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-21344

extensionSearchRepositoryList select has a hidden label

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • 15.10-rc-1
    • 15.8-rc-1
    • Extension
    • Unknown
    • N/A
    • N/A
    • 3.3.2 Labels or Instructions

    Description

      The label for the select with ID: #extensionSearchRepositoryList is .hidden .
      This hides it from Assistive technologies too and is not appropriate, it should be replaced with .sr-only , according to the HTML and CSS Codestyle > WCAG > Properly hide elements > Hiding visually and showing semantically

      See https://github.com/xwiki/xwiki-platform/blob/4f398665e912d3089ab2ebd278389ff24fba9240/xwiki-platform-core/xwiki-platform-web/xwiki-platform-web-templates/src/main/resources/templates/extension.vm#L62-L66

      Report from automatic tests:

      WCAG warnings in the test class [org.xwiki.extension.security.test.ui.AllIT]:
      _____
      
      Validation in the test method [extensionVulnerabilitiesAdmin]
      Check for [org.xwiki.extension.test.po.ExtensionAdministrationPage] at [http://xwikiweb:8080/xwiki/bin/admin/XWiki/XWikiPreferences?form_token=0A2PGwAKOGITtX0Up1xJRw&section=XWiki.Extensions].
      Found [1] items
      
      1: Select element must have an accessible name
      Description: Ensures select element has an accessible name
      Help URL: https://dequeuniversity.com/rules/axe/4.7/select-name?application=axeAPI
      Help: Select element must have an accessible name
      Impact: critical
      Tags: cat.forms, wcag2a, wcag412, section508, section508.22.n, ACT, TTv5, TT5.c
      
      HTML element: 
      	<select id="extensionSearchRepositoryList" name="repo">
      Selector: [#extensionSearchRepositoryList]
      Fix all of the following:
        Form element has explicit <label> that is hidden
      
      

      Attachments

        Activity

          People

            Lucas C Charpentier Lucas
            Lucas C Charpentier Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: