Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-21558

If a macro is modified by another user while the macro edit modal is open, we cannot update the macro

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Critical
    • 16.0.0-rc-1, 15.10.6
    • 14.10.19
    • Realtime
    • None
    • Integration
    • Unknown
    • N/A
    • N/A

    Description

      Follow these steps to reproduce:

      • Edit the same page in two browsers
      • in b1 open a macro, change a few things, but don't save yet
      • in b2 open the same macro, change something but don't save yet
      • in b1 save the macro
      • in b2 attempt to save the macro, observe the save fails

      Besides the fact that the macro is not updated, the editor becomes unusable. I noticed this exception in the JavaScript console, repeated multiple times:

      ckeditor.js:1126 Uncaught TypeError: Cannot read properties of undefined (reading 'getData')
          at e.<anonymous> (ckeditor.js:1126:245)
          at e.l (ckeditor.js:10:246)
          at e.<anonymous> (ckeditor.js:12:91)
          at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.editor.CKEDITOR.editor.fire (ckeditor.js:13:285)
          at CKEDITOR.htmlDataProcessor.toDataFormat (ckeditor.js:325:116)
          at $.getData (ckeditor.js:1467:265)
          at $.<anonymous> (ckeditor.js:380:6)
          at e.l (ckeditor.js:10:246)
          at e.<anonymous> (ckeditor.js:12:91)
          at window.CKEDITOR.window.CKEDITOR.dom.CKEDITOR.editor.CKEDITOR.editor.fire (ckeditor.js:13:285)
      

      Attachments

        Issue Links

          Activity

            People

              mflorea Marius Dumitru Florea
              mflorea Marius Dumitru Florea
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: