Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-21650

The XModal close button new style does not fit in its context

Details

    • Unknown
    • N/A
    • N/A

    Description


      The close button style has been updated, however its new style does not fit in the title bar of the template used for the AWM entry addition modal.

      Attachments

        Issue Links

          is caused by

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-21437 The XModal close button is not accessible

          • Major - Major loss of function.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-21600 Various close button modals do not use icons

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed

          Activity

            [XWIKI-21650] The XModal close button new style does not fit in its context
            Lucas C Charpentier Lucas added a comment - - edited

            Some of the changes in this ticket are really close to the ones for XWIKI-21600. The PR I'll start will fix a part of XWIKI-21600.

            Lucas C Charpentier Lucas added a comment - - edited Some of the changes in this ticket are really close to the ones for XWIKI-21600 . The PR I'll start will fix a part of XWIKI-21600 .
            MichaelHamann Michael Hamann added a comment - - edited

            Same for the go to dialog:

            MichaelHamann Michael Hamann added a comment - - edited Same for the go to dialog:
            Lucas C Charpentier Lucas added a comment -

            Tip from surli (repost from the live chat): I think the entry addition modal actually uses very old code in XS and it should be replaced by something more standard like bootstrap modal

            Lucas C Charpentier Lucas added a comment - Tip from surli (repost from the live chat): I think the entry addition modal actually uses very old code in XS and it should be replaced by something more standard like bootstrap modal
            Lucas C Charpentier Lucas added a comment -

            Caused by the change in style introduced in https://github.com/xwiki/xwiki-platform/commit/d4752ef520e01f289f5b3f418a0eb3e4ceb673dc

            Lucas C Charpentier Lucas added a comment - Caused by the change in style introduced in https://github.com/xwiki/xwiki-platform/commit/d4752ef520e01f289f5b3f418a0eb3e4ceb673dc

            People

              Lucas C Charpentier Lucas
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: