Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-22209

Deprecate NotificationFilterPreference#isActive

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Fixed
    • Major
    • 16.5.0-rc-1
    • 15.10.10
    • Notifications
    • None
    • Unknown
    • N/A
    • N/A

    Description

      The concept of active notification filter preferences does not make sense anymore, the javadoc says:

      A filter preference can either be active or passive. It the preference is active, then it should force the retrieval of notifications when used in conjunction with a {@link NotificationFilter}.

      On the other hand, a passive (non-active) notification filter should not automatically trigger the retrieval of notifications.

      This was probably valid back then when notifications were using a post-filtering mechanism to be retrieved, but now that we're using prefiltering by default it doesn't make sense anymore.

      Attachments

        Activity

          People

            surli Simon Urli
            surli Simon Urli
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: