Details
-
Bug
-
Resolution: Unresolved
-
Major
-
None
-
17.1.0
-
None
-
Unknown
-
Description
Across our codebase, we have a dozen way to check if a user is superadmin
- com.xpn.xwiki.internal.plugin.rightsmanager.UserIterator#isSuperAdmi
- com.xpn.xwiki.user.api.XWikiRightService#isSuperAdmin
- com.xpn.xwiki.user.impl.xwiki.AbstractXWikiAuthService#isSuperAdmin
- com.xpn.xwiki.user.impl.xwiki.XWikiRightServiceImpl#isSuperAdmin
- com.xpn.xwiki.internal.template.InternalTemplateManager.FilesystemTemplateContent#isPrivileged
- com.xpn.xwiki.user.impl.xwiki.XWikiRightServiceImpl#isSuperAdmin
- com.xpn.xwiki.user.impl.xwiki.XWikiRightServiceImpl#isSuperAdminOrProgramming
- org.xwiki.test.checker.internal.ProgrammingRightCheckerAuthorizationManager#check(org.xwiki.model.reference.DocumentReference, com.xpn.xwiki.doc.XWikiDocument)
- org.xwiki.user.internal.document.AbstractUserReferenceResolver#isSuperAdmin
It would be better to have a single source of truth, especially as some implementations might ne be aligned with each other
Attachments
Issue Links
- is related to
-
XWIKI-22815 Variable $isSuperAdmin is not computed correctly on subwikis
-
- Closed
-