The attachment selector create should be a button instead of link

AFAIU. the attachment selector always does things in a modal dialog. The "button" to open this dialog should be an actual button and not a disguised anchor.