Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23008

The attachment delete REST endpoint is modifying the cached document

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 17.2.0-rc-1, 16.10.6
    • 16.4.7
    • REST
    • None
    • Unknown
    • N/A
    • N/A

    Description

      Getting:

      java.lang.IllegalStateException: Abusive modification of the cached document 
-    at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2436) 
-    at com.xpn.xwiki.internal.doc.XWikiAttachmentList.updateList(XWikiAttachmentList.java:262) 
-    at com.xpn.xwiki.internal.doc.XWikiAttachmentList.remove(XWikiAttachmentList.java:157) 
-    at com.xpn.xwiki.doc.XWikiDocument.removeAttachment(XWikiDocument.java:5611) 
-    at com.xpn.xwiki.doc.XWikiDocument.removeAttachment(XWikiDocument.java:5597) 
-    at org.xwiki.rest.internal.resources.attachments.AttachmentResourceImpl.deleteAttachment(AttachmentResourceImpl.java:118)

      It's also a bit strange to use directly XWikiDocument for this, it should ideally use the public/script API and we usually do in those endpoint so ideally the fix should include adding an API to delete an attachment in api.Document.

      Attachments

        Issue Links

          depends on

          New Feature - A new feature of the product, which has yet to be developed. XWIKI-23009 Introduce an script Document API to remove an attachment

          • Major - Major loss of function.
          • Closed

          Activity

            People

              tmortagne Thomas Mortagne
              tmortagne Thomas Mortagne
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: