Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23139

Abusive modification of the cached document when installing a XAR extension still reproduces

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • 16.10.7, 17.3.0
    • 17.3.0-rc-1, 17.2.2
    • Extension - XAR
    • Windows 11 Pro, Chrome 135, using an instance of XWiki 17.2.2 on MySQL 9, Tomcat 11, reproducible also on Jetty/HSQL
    • Unknown

    Description

      Steps to reproduce

      1. Create an instance of XWiki 17.2.2 and/or 17.3.0 RC1 (tested on MySQL 9/ Tomcat 11.0.6 and on Jetty/HSQL demo version)
      2. Observe the logs from the Distribution Wizard

      Expected results

      No warnings/ errors are displayed.

      Actual results

      The following warnings are displayed in Distribution Wizard logs:

      Abusive modification of the cached document
      class java.lang.IllegalStateException: Abusive modification of the cached document
          at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2457)
          at com.xpn.xwiki.objects.BaseElement.setOwnerDocument(BaseElement.java:522)
          at com.xpn.xwiki.objects.BaseCollection.setOwnerDocument(BaseCollection.java:994)
          at com.xpn.xwiki.objects.BaseCollection.addField(BaseCollection.java:546)
          at com.xpn.xwiki.objects.classes.BaseClass.addField(BaseClass.java:196)
          at com.xpn.xwiki.objects.BaseCollection.safeput(BaseCollection.java:272)
          at com.xpn.xwiki.objects.BaseCollection.apply(BaseCollection.java:968)
          at com.xpn.xwiki.objects.classes.BaseClass.apply(BaseClass.java:1590)
          at com.xpn.xwiki.doc.AbstractMandatoryClassInitializer.updateDocument(AbstractMandatoryClassInitializer.java:78)
          at org.xwiki.annotation.internal.AnnotationClassDocumentInitializer.updateDocument(AnnotationClassDocumentInitializer.java:95)
          at org.xwiki.annotation.internal.CheckAnnotationClassEventListener.onEvent(CheckAnnotationClassEventListener.java:114)
          at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:338)
          at org.xwiki.observation.internal.DefaultObservationManager.notify(DefaultObservationManager.java:303)
          at com.xpn.xwiki.XWiki.afterSave(XWiki.java:2040)
          at com.xpn.xwiki.XWiki.saveDocument(XWiki.java:2130)
          at org.xwiki.extension.xar.internal.handler.packager.DocumentMergeImporter.saveDocumentSetContextUser(DocumentMergeImporter.java:213)
          at org.xwiki.extension.xar.internal.handler.packager.DocumentMergeImporter.saveDocument(DocumentMergeImporter.java:159)
          at org.xwiki.extension.xar.internal.handler.packager.DocumentMergeImporter.importDocument(DocumentMergeImporter.java:117)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importDocumentToWiki(Packager.java:230)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importXARToWiki(Packager.java:184)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importXARToWiki(Packager.java:157)
          at org.xwiki.extension.xar.internal.handler.packager.Packager.importXAR(Packager.java:148)
          at org.xwiki.extension.xar.internal.handler.XarExtensionHandler.installInternal(XarExtensionHandler.java:189)
          at org.xwiki.extension.xar.internal.handler.XarExtensionHandler.install(XarExtensionHandler.java:150)
          at org.xwiki.extension.handler.internal.DefaultExtensionHandlerManager.install(DefaultExtensionHandlerManager.java:85)
          at org.xwiki.extension.job.internal.AbstractExtensionJob.installExtension(AbstractExtensionJob.java:330)
          at org.xwiki.extension.job.internal.AbstractExtensionJob.applyAction(AbstractExtensionJob.java:233)
          at org.xwiki.extension.job.internal.AbstractExtensionJob.applyActions(AbstractExtensionJob.java:181)
          at org.xwiki.extension.job.internal.InstallJob.runInternal(InstallJob.java:140)
          at org.xwiki.job.AbstractJob.runInContext(AbstractJob.java:246)
          at org.xwiki.job.AbstractJob.run(AbstractJob.java:223)
          at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1144)
          at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:642)
          at java.base/java.lang.Thread.run(Thread.java:1583)

      No warnings/ errors on XWiki console. The issue couldn't be reproduced on XWiki 17.2.0.

      The stacktrace is similar to the one reported on XWIKI-23108.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              iandriuta Ilie Andriuta
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: