Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23274

Abusive modification of the cached document when adding a tag to a page

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • 16.10.9, 17.5.0-rc-1, 17.4.1
    • 17.4.0
    • None
    • Windows 11 Pro, Edge 137, using an instance of XWiki 17.4.0 on MariaDB 11.7, Tomcat 11.0.7
    • Unknown
    • N/A
    • N/A

    Description

      Steps to reproduce

      1. Add a tag to a page
      2. Observe the XWiki logs

      Expected results

      No warnings are displayed.

      Actual results

      The following stacktrace is displayed in XWiki logs:

      2025-06-05 17:09:38,569 [http-nio-1115-exec-7 - http://localhost:1115/xwiki/bin/view/aha/?xpage=documentTags&xaction=add&form_token=AgLaQNFajBFA1dI1qmz6lA&ajax=1&tag=tag1] WARN  c.x.x.d.XWikiDocument          - Abusive modification of the cached document [xwiki:aha.WebHome()]
      java.lang.IllegalStateException: Abusive modification of the cached document
              at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2457)
              at com.xpn.xwiki.objects.BaseElement.setOwnerDocument(BaseElement.java:522)
              at com.xpn.xwiki.objects.BaseCollection.setOwnerDocument(BaseCollection.java:994)
              at com.xpn.xwiki.objects.BaseObject.setOwnerDocument(BaseObject.java:424)
              at com.xpn.xwiki.doc.XWikiDocument.createXObject(XWikiDocument.java:2995)
              at com.xpn.xwiki.doc.XWikiDocument.newXObject(XWikiDocument.java:8916)
              at com.xpn.xwiki.doc.XWikiDocument.getXObject(XWikiDocument.java:8962)
              at com.xpn.xwiki.doc.XWikiDocument.getObject(XWikiDocument.java:8981)
              at com.xpn.xwiki.plugin.tag.TagPlugin.setDocumentTags(TagPlugin.java:148)
              at com.xpn.xwiki.plugin.tag.TagPlugin.addTagsToDocument(TagPlugin.java:475)
              at com.xpn.xwiki.plugin.tag.TagPluginApi.addTagsToDocument(TagPluginApi.java:240)
              at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
              at java.base/java.lang.reflect.Method.invoke(Method.java:580)
              at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:571)
              at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:554)
              at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:221)
              at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:368)
              at org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:704)
              at org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:75)
              at org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:242)
              at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:147)
              at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:171)
              at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:147)
              at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:171)
              at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:147)
              at org.apache.velocity.runtime.directive.VelocimacroProxy.render(VelocimacroProxy.java:217)
              at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:331)
              at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:261)
              at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:304)
              at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:147)
              at org.apache.velocity.runtime.parser.node.ASTElseIfStatement.render(ASTElseIfStatement.java:108)
              at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:190)
              at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:439)
              at org.apache.velocity.Template.merge(Template.java:358)
              at org.apache.velocity.Template.merge(Template.java:262)
              at org.xwiki.velocity.internal.InternalVelocityEngine.evaluate(InternalVelocityEngine.java:233)
              at com.xpn.xwiki.internal.template.VelocityTemplateEvaluator.evaluateContent(VelocityTemplateEvaluator.java:107)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.evaluateContent(TemplateAsyncRenderer.java:219)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.renderVelocity(TemplateAsyncRenderer.java:174)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.render(TemplateAsyncRenderer.java:135)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.render(TemplateAsyncRenderer.java:54)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.lambda$syncRender$0(DefaultAsyncRendererExecutor.java:284)
              at com.xpn.xwiki.internal.security.authorization.DefaultAuthorExecutor.call(DefaultAuthorExecutor.java:98)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.syncRender(DefaultAsyncRendererExecutor.java:284)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.render(DefaultAsyncRendererExecutor.java:267)
              at org.xwiki.rendering.async.internal.block.DefaultBlockAsyncRendererExecutor.render(DefaultBlockAsyncRendererExecutor.java:154)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:907)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:869)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:849)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:835)
              at com.xpn.xwiki.internal.template.DefaultTemplateManager.render(DefaultTemplateManager.java:91)
              at com.xpn.xwiki.internal.template.DefaultTemplateManager.render(DefaultTemplateManager.java:85)
              at com.xpn.xwiki.XWiki.evaluateTemplate(XWiki.java:2570)
              at com.xpn.xwiki.web.Utils.parseTemplate(Utils.java:180)
              at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:650)
              at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:338)
              at com.xpn.xwiki.web.LegacyActionServlet.service(LegacyActionServlet.java:111)
              at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:710)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:130)
              at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:123)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.wysiwyg.filter.ConversionFilter.doFilter(ConversionFilter.java:72)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:53)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SetHTTPHeaderFilter.doFilter(SetHTTPHeaderFilter.java:66)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.resource.servlet.RoutingFilter.doFilter(RoutingFilter.java:135)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:211)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SafeRedirectFilter.doFilter(SafeRedirectFilter.java:106)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.ResolveRelativeRedirectFilter.doFilter(ResolveRelativeRedirectFilter.java:129)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:120)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:167)
              at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:79)
              at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:483)
              at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:116)
              at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
              at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:666)
              at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
              at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:343)
              at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:396)
              at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
              at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:903)
              at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1744)
              at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
              at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
              at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:637)
              at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:59)
              at java.base/java.lang.Thread.run(Thread.java:1583)

       

      Attachments

        Activity

          People

            tmortagne Thomas Mortagne
            iandriuta Ilie Andriuta
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: