Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23332

The width of the required rights modal depends on the displayed rights

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 17.4.0
    • None
    • Unknown

    Description

      Steps to reproduce:

      1. Create a page with an HTML macro with wiki=true.
      2. Go to the information tab
      3. Click on "Review required rights"
      4. Click "Enforce required rights"

      Expected result:

      The width of the modal doesn't change.

      Actual result:

      The width of the modal changes.

      This could also happen in general when the names of rights are translated and widths of the translations are larger than the English text.

      It was intentional to adapt the width of the dialog to the displayed rights, but there are two issues:

      1. As shown in the reproduction steps, the width is not always the same.
      2. If the text gets a lot wider, it might not fit on small screens. For small screens, there is the vertical layout, but it is only triggered below a fixed width and that width might not be enough to show the rights in horizontal layout.

      Instead of relying on a fixed width, the switch between horizontal and vertical layout should depend on the actual width of the rights in the horizontal layout. Additionally, we could decide to permanently increase the width of the modal to ensure that in most cases, we use the horizontal layout.

      Attachments

        Activity

          People

            MichaelHamann Michael Hamann
            MichaelHamann Michael Hamann
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: