Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23747

Some misalignments and other UI issues on macro edit modals

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Blocker
    • 18.0.0-rc-1, 17.10.0
    • 17.9.0-rc-1
    • Rendering
    • Windows 11 Pro, Firefox 145, using an instance of XWiki 17.9.0 RC1 on PostgreSQL 17, Tomcat 11.0.13
    • Unknown

    Description

      Steps to reproduce

      1. Edit a page with CKEditor
      2. Click on Insert > Other Macros and choose 'Display' or 'Include' macro
      3. Click 'Select' button
      4. Observe the elements from the modal

      Expected results

      All elements are blended into the modal and aligned properly with the others,

      Actual results

      • Some macro elements seem "nested" inside the modal, instead of integrated; this can be reproduced on 'Display' and 'Include' macros with the "reference" box;
      • The page picker drop-down left and right margins inside the "reference" box are shorter and thus misaligned with the rest of the input fields/ drop-downs;
      • On 'Display' and 'Include' macros the "reference" box title looks a bit out of place, since the box contains already a "Page" title (in my opinion, "reference" title should be removed and "Page" should be marked as "Required" instead);
      • The left and right sides of "Optional parameters" tab looks outside of the alignment with other modal elements (input fields, titles, hints);
      • The "(Required)" and "(Advanced)" labels should be lowered a little bit, to be aligned inline with the rest of the text (title) to which they are attached - previously the fields required were marked only by an asterisk '*' which was placed higher than the text and maybe this is where the misalignment comes from.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              iandriuta Ilie Andriuta
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: