Add automated test for "Upgrade Extension using Updater"

The manual test is here: Upgrade Extension using Updater

The test checks if upgrading an extension from Updater view in Extension Manager works properly.

Matrix discussion: https://matrix.to/#/!zdPfnFC0pUfwN5kZ4LKP2dXZ2jC266yFWKNeqgmJd4E/$4B7s1gtmNY2j8fhd0zLG3LN-tLureFNUpnvxWV1o9cA?via=matrix.xwiki.com&via=matrix.org&via=uni-wuppertal.de
 
Ilie Andriuta: Hi! Continuing the manual tests migration, there is a test about checking if upgrading an extension from Updater works properly: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Upgrade%20Extension. I've checked https://github.com/xwiki/xwiki-platform/blob/451d41a9be017e34e84fb716173de73b6df09121/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-tests/src/test/java/org/xwiki/test/ui/extension/ExtensionIT.java#L712 but I'm not sure automated tests exist. Can you please confirm whether the automated test exists for it or not and maybe providing the link to it? Thanks!

Vincent Massol: Ilie Andriuta: what about https://github.com/xwiki/xwiki-platform/blob/43eec3c4913617a2c375790be947e6237ab77477/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-tests/src/test/java/org/xwiki/test/ui/extension/ExtensionIT.java#L718 ?

xwiki-platform/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-tests/src/test/java/org/xwiki/test/ui/extension/ExtensionIT.java at 43eec3c4913617a2c375790be947e6237ab77477
the extension is upgraded by clicking on the "upgrade" button though:

// Upgrade the extension.
ExtensionAdministrationPage adminPage = ExtensionAdministrationPage.gotoPage();
ExtensionPane extensionPane =
adminPage.getSearchBar().clickAdvancedSearch().search(extensionId, newVersion).getExtension(0);
assertEquals("remote-installed", extensionPane.getStatus());
assertEquals("Version 1.3 is installed", extensionPane.getStatusMessage());
extensionPane = extensionPane.upgrade();
I don't think it's testing the Updater view , ie https://extensions.xwiki.org/xwiki/bin/view/Extension/Extension%20Manager%20Application#HExtensionUpdater
XWiki Extension Manager Application
Ilie Andriuta: yes, that's what I've observed...it should test "Check for updates" also
and then check the progress bar
Vincent Massol: checking if we have a PO for that view
I don't see any at https://github.com/xwiki/xwiki-platform/blob/a7a7c0c2c0d5690195d7a64d2b82c60f895ce46b/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-pageobjects/src/main/java/org/xwiki/extension/test/po so I don't think we are testing that view in our automated tests

xwiki-platform/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-pageobjects/src/main/java/org/xwiki/extension/test/po at a7a7c0c2c0d5690195d7a64d2b82c60f895ce46b
ah wait
Thomas: Depends what you call "that view".
We have PO for the progress and the log.
Vincent Massol: found https://github.com/xwiki/xwiki-platform/blob/83dcf406fc691c66a68638cc3206a145bd1f3fcc/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-pageobjects/src/main/java/org/xwiki/extension/test/po/distribution/ExtensionsDistributionStep.java#L32

xwiki-platform/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-pageobjects/src/main/java/org/xwiki/extension/test/po/distribution/ExtensionsDistributionStep.java at 83dcf406fc691c66a68638cc3206a145bd1f3fcc
Ilie Andriuta: ok, so we do have a test for checking the updates
Thomas: AFAIK the whole extension UI is covered by PO
Vincent Massol: I see "updater" mentioned in getDriver().waitUntilElementIsVisible(By.xpath("//div[@class='extensionUpdater']/p[@class='xHint']")); so maybe it's from the udater ?
but the javadoc is weird -> The Outdated Extensions step UI.
from the javadoc it doesn't seem to be the Updater view from the EM
Thomas: Vincent Massol
but the javadoc is weird -> The Outdated Extensions step UI.
that step use the updater
See the todo at https://github.com/xwiki/xwiki-platform/blob/83dcf406fc691c66a68638cc3206a145bd1f3fcc/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-pageobjects/src/main/java/org/xwiki/extension/test/po/distribution/ExtensionsDistributionStep.java#L34

xwiki-platform/xwiki-platform-core/xwiki-platform-extension/xwiki-platform-extension-test/xwiki-platform-extension-test-pageobjects/src/main/java/org/xwiki/extension/test/po/distribution/ExtensionsDistributionStep.java at 83dcf406fc691c66a68638cc3206a145bd1f3fcc 
Vincent Massol: Thomas: how is ExtensionsDistributionStep used in a test?
Thomas: Vincent Massol
Thomas: how is ExtensionsDistributionStep used in a test?
We have the upgrade tests.
Vincent Massol: I can't find a usage for that class
ok found it
Thomas: That's because you search for the class, search for checkForUpdates calls.
Vincent Massol: https://github.com/xwiki/xwiki-platform/blob/aac11f147b2ad13c7376192891912ff290472e09/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-upgrade/src/main/java/org/xwiki/test/ui/UpgradeTest.java

xwiki-platform/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-upgrade/src/main/java/org/xwiki/test/ui/UpgradeTest.java at aac11f147b2ad13c7376192891912ff290472e09
(not exactly sure why IJ didn't see the usage)
Ilie Andriuta: so it seems to be there even if it's not perfect (there should be an EM test for it IMO, and right now it's tested through the DW tests)
Ilie Andriuta: is this "Check for updates" https://github.com/xwiki/xwiki-platform/blob/aac11f147b2ad13c7376192891912ff290472e09/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-upgrade/src/main/java/org/xwiki/test/ui/UpgradeTest.java#L500 the same with the one on the EM from Administration?

xwiki-platform/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-upgrade/src/main/java/org/xwiki/test/ui/UpgradeTest.java at aac11f147b2ad13c7376192891912ff290472e09
Thomas: Vincent Massol
Ilie Andriuta: so it seems to be there even if it's not perfect (there should be an EM test for it IMO, and right now it's tested through the DW tests)
But it does not check much.
Ilie Andriuta: ah, ok, just answered above
Thomas: The upgrade test is just interrested in waiting for the job to be finished.
Vincent Massol: right
// TODO: check some stuff
^^is a bit light
at https://github.com/xwiki/xwiki-platform/blob/aac11f147b2ad13c7376192891912ff290472e09/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-upgrade/src/main/java/org/xwiki/test/ui/UpgradeTest.java#L502

xwiki-platform/xwiki-platform-core/xwiki-platform-test/xwiki-platform-test-upgrade/src/main/java/org/xwiki/test/ui/UpgradeTest.java at aac11f147b2ad13c7376192891912ff290472e09
Thomas: that part was not really import for the upgrade test