Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-24154

The .label bootstrap class does not look correct inline

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Minor
    • None
    • 18.2.0-rc-1
    • Bootstrap
    • None
    • Unknown

    Description

      According to https://getbootstrap.com/docs/3.4/components/#badges the .badge class should be usable inline.

      On xwiki.org, we noticed that the version macro looks odd (https://www.xwiki.org/xwiki/bin/view/DocApp/Code/VersionMacro ). This macro uses the badge class from our bootstrap fork to style its inline span.

      The badge is off center and there's no spacing with the line below. Additionally the line-height is different from regular text.

      Note that this class is barely used in XS (only place I could find is for the notification count on the topbar menu, which is not inline and heavily customized).
      ___
      This issue can be solved in two radically different ways:

      • Provide a fix to the .badge class so that it looks supported
      • Explicitely state that it's not supported by XWiki and move its styles to a legacy module.

      Attachments

        Activity

          People

            Unassigned Unassigned
            Lucas C Charpentier Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated: