Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-24474

Add automated tests for "Solr Reindex" and "Solr Delete from Index"

    XMLWordPrintable

Details

    • Integration
    • Unknown
    • N/A
    • N/A

    Description

      This is the response from Claude Code:

      ❯ There are 2 tests related to the Index feature in Search from Administration: https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Solr%20Delete%20from%20Index and https://test.xwiki.org/xwiki/bin/view/Administration%20Tests/Solr%20Reindex.

      Let me know if there are existing automated tests covering these manual tests.

      ⏺ I'll research whether there are existing automated tests covering these two manual Solr admin tests. Let me explore the codebase.

      ⏺ 2 Explore agents finished (ctrl+o to expand)
      ├ Find Solr admin UI tests · 23 tool uses · 74.5k tokens
      │ ⎿ Done
      └ Find Solr reindex job and admin section · 12 tool uses · 64.7k tokens
      ⎿ Done

      ⏺ Let me verify the agents' findings by reading the key files directly.

      Read 3 files (ctrl+o to expand)

      ⏺ Let me look at the actual manual test pages to understand precisely what they verify, so I can accurately assess coverage.

      Called plugin:context-mode:context-mode 2 times (ctrl+o to expand)

      ⏺ I have a complete picture now. Here's the answer to your question.

      Short answer: No — neither manual test is covered by an existing automated test.

      The underlying logic has some unit/integration coverage, but the actual manual-test workflow (the Admin → Search → "Action" dropdown → Apply → success message + queue size + search verification) is not automated.

      What the manual tests do:

      Both navigate to Administer Wiki → Search → Search, pick an action from the Action drop-down, select "Entire farm" from the Wiki drop-down, click Apply, and verify:

      • Solr Delete from Index verifies "Delete successfully triggered" message + queue size 0, then a search returns no results │
      • Solr Reindex verifies "Reindex successfully triggered" message + queue size updates in real time 

      This form is implemented in xwiki-platform-search-solr-ui/src/main/resources/XWiki/SolrSearchAdmin.xml (the index/delete/reindex action dropdown + wiki selector).

      What automated tests exist today (and what they miss)

      • SolrSearchIT.java (xwiki-platform-search-test/xwiki-platform-search-test-docker/.../ui/SolrSearchIT.java) — uses the SearchAdministrationPage page object, but only exercises search exclusions, locale search, search limits, and the suggest service. It never touches the Action dropdown / Apply / reindex / delete.
      • SolrIndexerIT.java (same module) — sortOrder() verifies the internal indexer via DiffDocumentIterator (Solr vs DB consistency). Not the admin UI form.
      • IndexerJobTest.java (xwiki-platform-search-solr-api/.../job/IndexerJobTest.java) — unit tests for the IndexerJob add/update/delete actions at the job level. Not the UI.

      The blocker for UI automation: the SearchAdministrationPage page object (xwiki-platform-search-test-pageobjects/.../SearchAdministrationPage.java) only exposes getSearchEngineField() and getSearchExclusionsField() — it has no methods for the Action dropdown, Wiki selector, Apply button, success message, or queue
      size that these two manual tests rely on.

      Verdict:

      • Solr Reindex → partially covered at the logic level, not at the UI/manual-workflow level
      • Solr Delete from Index → not covered at any level via the admin UI workflow

      Since you only asked me to check, I'll stop here rather than presume.

      Attachments

        Activity

          People

            vmassol Vincent Massol
            iandriuta Ilie Andriuta
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: