Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-25445

The message macros can't be found by their name in Quick Actions

    XMLWordPrintable

Details

    • Bug
    • Resolution: Unresolved
    • Major
    • None
    • 17.10.14, 18.8.0
    • CKEditor
    • None
    • Unknown

    Description

      The Info Message, Warning Message, Error Message and Success Message macros are listed in Quick Actions as "Info Box", "Warning Box", "Error Box" and "Success Box". A user who types the name shown everywhere else for these macros, in the Insert Macro dialog, the Edit Macro dialog and the documentation, gets no result.

      Steps to reproduce

      1. Edit a page with the WYSIWYG editor.
      2. Type /info message, then /warning message.

      Expected

      The Info Message and Warning Message macros are listed first.

      Actual

      No result. /info and /warning find them, under the names "Info Box" and "Warning Box". The same happens with the translated names of the macros, for example the German "Informationshinweis" and "Fehlerhinweis".

      Cause

      The xwiki-slash plugin adds a dedicated Quick Action for each of these macros, with the id macro-info, macro-warning, macro-error and macro-success, a default content, and the label of the toolbar Insert menu, xwiki-toolbar.infoBox and the like. When the xwiki-macro plugin then adds an action for each macro, it skips the macros that already have an action with that id, so the entry carrying the name of the macro is never added.

      Proposal

      Name the dedicated Quick Actions after the macros, using the translated name of the macro, so that the name of the macro finds them. The Insert menu of the toolbar uses the same labels and can keep them.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: