Details
-
Improvement
-
Resolution: Unresolved
-
Major
-
None
-
17.10.14, 18.8.0
-
None
-
Unknown
-
Description
The notifications macro takes the number of events to list in a plain text field of the Edit Macro dialog, so any text can be typed and the user only sees the result after the macro renders.
The parameter is declared in NotificationsMacro.xml. The activity macro is left out: it is a legacy macro, to be deprecated in XWIKI-25515.
The main problem:
- The parameter is declared without a numeric type, so the dialog cannot offer a number field even once one exists. It needs an integer type and a minimum of 1.
Depends on
Most of these fields cannot be offered before these generic changes, each giving the macro the means to declare the expected value:
- XWIKI-25182, which gives a number input to the parameters of a numeric type.
- XWIKI-25197, which lets a wiki macro parameter declare its minimum and maximum.
KOs covered
| Macro | Criterion | Parameter | Problem | Depends on |
|---|---|---|---|---|
| notifications | C4 input-assistance | count | A plain text field for the number of events: count="-3" is accepted and shows one event. | XWIKI-25182, XWIKI-25197 |
Impact found on macro fluidity
This KO comes from the WYSIWYG usability audit of the macros, under the criterion C4 input-assistance of its usability criteria. The page of the macro, linked in the table, has the full notes and the steps to reproduce. Fixing them means changing the declaration of the parameters in the macro definitions.
Attachments
Issue Links
- depends on
-
XWIKI-25182 Numeric macro parameters accept any text in the Edit Macro dialog
-
- Open
-
-
XWIKI-25197 Allow wiki macro parameters to declare a range or a format for their value
-
- Open
-