The Attachment Selector macro declares inline support but breaks the sentence it is placed in

The Attachment Selector macro declares that it supports the inline mode, but its output is a block: placed in the middle of a sentence, it breaks the sentence in two.

Steps to reproduce

1. Edit a page in the wiki editor and write a sentence with the macro inside it:

   Before {{attachmentSelector classname="..." property="attachment"/}} after.
   

2. View the page.

• Expected: the selector inside the sentence, between "Before" and "after".
• Actual: <p>Before <p><span class="displayed">name</span></p> after.</p>, a paragraph inside a paragraph, which breaks the line. With savemode="direct" the output is a div holding a paragraph and the button, so the sentence is split too.

The macro is defined in AttachmentSelector.xml. The fix is either to output inline elements, a span instead of the paragraph and the div, when the macro is called inline, or to stop declaring the inline support.

KOs covered

Impact found on macro fluidity

This KO comes from the WYSIWYG usability audit of the macros, under the criterion E4 inline-support of its usability criteria, which checks that the inline support a macro declares matches its behavior. The page of the macro, linked in the table, has the full notes.