Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-25764

Stop evaluating Velocity in the WAR stylesheets that no longer need it

    XMLWordPrintable

Details

    • Improvement
    • Resolution: Unresolved
    • Major
    • None
    • 17.10.15
    • None
    • Unknown

    Description

      Once the color theme Velocity variables are removed from them, 17 stylesheets of the WAR contain no Velocity code anymore. They are still requested with Velocity evaluation, through $xwiki.ssfx.use('...', true) or the forceSkinAction parameter, sometimes with a colorTheme parameter, in about 30 places of the templates and wiki pages.

      The stylesheets are: diff.css, wizard.css, usersandgroups.css, tags.css, history.css, comments.css, fullScreen.css, job.css, modalPopup.css, picker.css, information.css, livevalidation.css, resubmit.css, actionButtons.css, compactLocationPicker.css, locationPicker.css and select.css.

      For a performance improvement, we should request these stylesheets without Velocity evaluation, so that they are served as static resources.

      Visible change: none.

      Attachments

        Issue Links

          Activity

            People

              Unassigned Unassigned
              Lucas C Charpentier Lucas
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated: