Attachments' temp files persist past shutdown of tomcat.

To repeat:
Start xwiki in tomcat, check /usr/share/tomcat5.5/temp (or whatever is the result of calling System.getProperty("java.io.tmpdir"))
Upload a file,
ls /usr/share/tomcat5.5/temp
note the new temp file
shutdown tomcat
ls /usr/share/tomcat5.5/temp
note the file is still there.

commons.fileupload gives files names which are guaranteed unique for that classloader. When the servlet is restarted, the filenames are no longer guaranteed unique and this might cause subtle and difficult bugs.