Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-7138

Search suggest does not use translation keys (Show all results... and No results!)

    Details

    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      Some words are hardcoded instead of using translation keys.
      There are particulary two strings :

      • Show all results... which is in searchSuggest.js
        new XWiki.widgets.XListItem( "Show all results...", {
        I added the following key : $msg.get('xwiki.lucene.showresults')
        new XWiki.widgets.XListItem( "$msg.get('xwiki.lucene.showresults')", {
      • No results! which is in suggest.js
        shownoresults:true,noresults:"No results!",maxheight:250
        I added the following key : $msg.get('xwiki.lucene.noresults') :
        shownoresults:true,noresults:"$msg.get('xwiki.lucene.noresults')",maxheight:250

      suggest.js is not interpreted, so you must edit javascript.vm :
      $xwiki.jsfx.use('uicomponents/suggest/suggest.js')
      => $xwiki.jsfx.use('uicomponents/suggest/suggest.js', true)

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sdumitriu Sergiu Dumitriu
                Reporter:
                nlemoine Nicolas Lemoine
              • Votes:
                1 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Date of First Response: