Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-7193

Avoid injecting RenderingCache and DocumentDisplayer in all instance of XWikiDocuments

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.3-milestone-2
    • Fix Version/s: 3.3-rc-1
    • Component/s: Old Core
    • Labels:
      None
    • Difficulty:
      Unknown
    • Similar issues:

      Description

      Direct injections of components used only partially cause them to be instantiated too early, and for many tests, even before the whole environment is ready. Please avoid injecting stuffs in private old code objects, without a real need.
      In this particular case, we have those in XWikiDocument because of the getRenderedContent() which is itself misplaced.

      I am moving the lookup into that function, using the private variables as a cache.

        Attachments

          Activity

            People

            Assignee:
            softec Denis Gervalle
            Reporter:
            softec Denis Gervalle
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: