Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-8929

Remove ugly HTML-escape hack in AttachmentDiff#toString

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 5.0-milestone-1
    • Fix Version/s: 5.0-milestone-2
    • Component/s: Old Core
    • Labels:
      None
    • Tests:
      Unit
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      toString() methods should not be used as displayers. They shouldn't be substitutes for displayers. They should be used for printing logs/exceptions.

      FTR this code is used to display attachment diff in the diff UI and in the watchlist HTML email.

      Added in rev 62368e9423925fbd496a5cc057a076b37b62f9ee with message "[misc] Improve javadoc, add AttachmentDiff.toString()"

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                sdumitriu Sergiu Dumitriu
                Reporter:
                vmassol Vincent Massol
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Date of First Response: