XWiki Platform
  1. XWiki Platform
  2. XWIKI-9708

Repair phase is not executed nor prompted on subwikis when Upgrade All Wikis option is selected from DW

    Details

    • Development Priority:
      High
    • Difficulty:
      Medium
    • Similar issues:

      Description

      Steps to reproduce:

      • setup a 4.1.4 XEM (I used TOmcat + MySQL)
      • manually import the manager-ui-all.xar (since there is no DW on this version)
      • install workspaces template
      • create a workspace
      • shudown and replace the war with a XE 5.2.2-SNAPSHOT (we only have the XE war since we don't build XEM anymore)
      • start and DW kicks in
      • from the DW, select that "This is an upgrade", and select 4.1.4 as the current version
      • the repair step kicks in (for the main wiki). Click on Repair, this will upgrade the main wiki.
      • after the main wiki is upgraded, for the rest of the wikis select "Upgrade All Wikis"
      • starting to upgrade the other wikis (I started with workspaces template) I got a ton of merge conflicts. Same for the workspace I created earlier.

      It seems that the repair phase only executes on the Main wiki.

        Activity

        Hide
        Marius Dumitru Florea added a comment -

        Sorin Burjan This isn't new and it's not only about the repair. When you choose to "Upgrade All Wikis" you don't get the Distribution Wizard for subwikis and so any features that DW has (including the repair) are not available any more (except for the extension upgrade which can be done from the Extension Manager UI also). This was made somehow by design, so it's not really a bug. Being able to repair a subwiki when "Upgrade All Wikis" is selected would be an improvement and requires significant changes I think. The general question is: when you add a new step or feature to the DW that is applicable to subwikis, how do you make it available when "Upgrade All Wikis" is selected? First we would need to agree on the workflow: you upgrade the main wiki, you select "Upgrade All Wikis" and then? Currently we display the list of extensions from each wiki and you can upgrade them. Where would the XAR repair UI be integrated for instance? In any case this is not just a simple bug fix and definitely not something that should be done on the rush.

        Show
        Marius Dumitru Florea added a comment - Sorin Burjan This isn't new and it's not only about the repair. When you choose to "Upgrade All Wikis" you don't get the Distribution Wizard for subwikis and so any features that DW has (including the repair) are not available any more (except for the extension upgrade which can be done from the Extension Manager UI also). This was made somehow by design, so it's not really a bug. Being able to repair a subwiki when "Upgrade All Wikis" is selected would be an improvement and requires significant changes I think. The general question is: when you add a new step or feature to the DW that is applicable to subwikis, how do you make it available when "Upgrade All Wikis" is selected? First we would need to agree on the workflow: you upgrade the main wiki, you select "Upgrade All Wikis" and then? Currently we display the list of extensions from each wiki and you can upgrade them. Where would the XAR repair UI be integrated for instance? In any case this is not just a simple bug fix and definitely not something that should be done on the rush.
        Hide
        Thomas Mortagne added a comment - - edited

        Currently we display the list of extensions from each wiki and you can upgrade them

        This is a bit more than that since there is a special step added in 5.2 to upgrade subwikis default UI based on distribution configuration so we are not at basic extension level anymore.

        In any case we are far from a bugfix and it's also far from being a blocker for 5.2.2. Is this situation worst than any version in the past ? Of course not.

        You can still use the default mode which is to upgrade each wiki separately. It's not like the current "upgrade all wikis" special step was really doing everything in one job either.

        Show
        Thomas Mortagne added a comment - - edited Currently we display the list of extensions from each wiki and you can upgrade them This is a bit more than that since there is a special step added in 5.2 to upgrade subwikis default UI based on distribution configuration so we are not at basic extension level anymore. In any case we are far from a bugfix and it's also far from being a blocker for 5.2.2. Is this situation worst than any version in the past ? Of course not. You can still use the default mode which is to upgrade each wiki separately. It's not like the current "upgrade all wikis" special step was really doing everything in one job either.
        Hide
        Vincent Massol added a comment -

        Ok then I suggest the following for 5.2.2:

        • Mark the "upgrade all wikis" feature as experimental in the UI and explain the potential consequences on a not clean wiki.
        Show
        Vincent Massol added a comment - Ok then I suggest the following for 5.2.2: Mark the "upgrade all wikis" feature as experimental in the UI and explain the potential consequences on a not clean wiki.
        Hide
        Sorin Burjan added a comment -

        I have retested and when selecting the default Upgrade option ("Upgrade current wiki"), DW does kick in when accessing the subwiki. Also, I have the repair phase using this case.
        Except some merge issues of my workspace, I was able to properly upgrade my wiki.
        So I confirm that the issue hits only when "Upgrade All Wikis" option is selected.

        Show
        Sorin Burjan added a comment - I have retested and when selecting the default Upgrade option ("Upgrade current wiki"), DW does kick in when accessing the subwiki. Also, I have the repair phase using this case. Except some merge issues of my workspace, I was able to properly upgrade my wiki. So I confirm that the issue hits only when "Upgrade All Wikis" option is selected.
        Hide
        Sorin Burjan added a comment -

        I also agree with Vincent Massol's proposal

        Show
        Sorin Burjan added a comment - I also agree with Vincent Massol 's proposal
        Hide
        Marius Dumitru Florea added a comment -

        In the end I choose to reuse on the 'Wikis' step the repair UI you get on the first step (for the main wiki UI). See the attached image.

        Show
        Marius Dumitru Florea added a comment - In the end I choose to reuse on the 'Wikis' step the repair UI you get on the first step (for the main wiki UI). See the attached image.

          People

          • Assignee:
            Marius Dumitru Florea
            Reporter:
            Sorin Burjan
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:
              Date of First Response: