Uploaded image for project: 'XWiki Commons'
  1. XWiki Commons
  2. XCOMMONS-1819

Images embedded using base64 data URI slow down the HTML diff computation

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 11.10
    • Fix Version/s: 11.10.1, 12.0-rc-1
    • Component/s: Diff
    • Labels:
      None
    • Tests:
      Integration
    • Development Priority:
      High
    • Difficulty:
      Medium
    • Similar issues:

      Description

      The issue is that the diff is computed at character level and the base64 data URI leads to a very large patch. We don't need that level of detail for HTML attributes, like we need for text nodes, because attribute value changes are not marked independently visually. We mark the entire element as modified. Se we need to treat text nodes and attribute nodes differently.

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mflorea Marius Dumitru Florea
                Reporter:
                mflorea Marius Dumitru Florea
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: