Uploaded image for project: 'XWiki Rendering'
  1. XWiki Rendering
  2. XRENDERING-6

Id are not unique when included document or macro content has the same headers as the top document

    XMLWordPrintable

Details

    • Integration
    • N/A
    • N/A
    • Pull Request accepted

    Description

      Included document should use the same IdGenerator than root document.

      Here are some solutions:

      1. an api to provide the IdGenerator to the parser and make include macro give the root document IdGenerator to the parser
      2. store the IdGenerator in the Execution context (but this means add another dependency to rendering module)
      3. regenerate included XDOM ids in the include macro
      4. re-check and fix all ids in the renderer (which means all renderers need to take care of that)
      5. completely remove ids from XDOM/parsers and generate then in the renderer (but this mean we need to find another way to support internal link to other blocks, we already tried that...)

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. CONFLUENCE-103 NoSuchMethodError in ConfluenceXWikiGeneratorListener in XWiki 13.10.4+/14.2+

          • Blocker - Blocks development and/or testing work, production could not run.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. XRENDERING-578 Header anchors should be unique

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-19535 Heading ids are not necessarily unique when using the include or display macro

          • Major - Major loss of function.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. XRENDERING-461 TOC macro can generate invalid links when there are included pages

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Bug - A problem which impairs or prevents the functions of the product. XRENDERING-3 Generated header id should be forced unique

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. XWIKI-15289 HTML headings are not correctly rendered in templates

          • Major - Major loss of function.
          • Open

          New Feature - A new feature of the product, which has yet to be developed. XWIKI-6721 The include and display macros should have an option to filter out the first heading in the included document or section

          • Major - Major loss of function.
          • Closed

          Activity

            People

              MichaelHamann Michael Hamann
              tmortagne Thomas Mortagne
              Votes:
              4 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: