Loading...

Details

Type: Bug
Resolution: Fixed
Priority: Critical
Fix Version/s: 6.3-rc-1
Affects Version/s: 6.2-rc-1
Component/s: App Within Minutes
Labels:
- bugfixingday

Difficulty:
Unknown
Documentation:
n/a
Documentation in Release Notes:
n/a
Similar issues:

Description

Steps to reproduce:

Create a new app with AWM
In the first step choose a name that includes a special character; for ex. use "my first app" (includes spaces)
Add at least a field
Add a new entry to the app
Go to the app homepage
Click on "Delete all entries"
Click Yes

You get a "Failed to execute the velocity macro" error with content similar to this one:

org.xwiki.rendering.macro.MacroExecutionException: Failed to evaluate Velocity Macro for content [#set ($appName = $request.appName)
#set ($scope = $request.scope)
#if ("$!appName" != '')
  #set ($dataHomeRef = $services.model.createDocumentReference($xcontext.wiki, $appName, 'WebHome'))
  #set ($dataHomeDoc = $xwiki.getDocument($dataHomeRef))
  #set ($liveTableObj = $dataHomeDoc.getObject('AppWithinMinutes.LiveTableClass'))
  #set ($classFullName = $liveTableObj.getProperty('class').value)
  ## Make sure a valid application name has been passed, otherwise stop here.
  #if ("$!classFullName" != '')
    #if ($request.confirm == '1')
      ## CSRF protection.
      #if(!$services.csrf.isTokenValid($request.form_token))
        $response.sendRedirect($services.csrf.getResubmissionURL())
        #stop
      #end
      ##
      #set ($classRef = $services.model.resolveDocument($classFullName))
      ##
      ## Common values for both cases.
      #set ($deleteQueryString = "WHERE doc.space in (:spaces)")
      #set ($deleteQuerySpaces = [$appName])
      ##
      #if ("$!scope" == 'entries')
        ## Delete only the application's entries (just data) from the data space.
        ##
        ## Note: XWQL does not support parametrised object class, so we just have to push it directly in the query string.    
        #set ($deleteQueryString = "FROM doc.object($classFullName) as obj $deleteQueryString")
      #else
        ## Delete the entire application (code + data spaces).
        ##
        #set ($codeSpaceName = $classRef.lastSpaceReference.name)
        #set ($discard = $deleteQuerySpaces.add($codeSpaceName))
      #end
      ##
      ## Run the query and delete the documents.
      #set ($deleteQuery = $services.query.xwql($deleteQueryString))
      #set ($discard = $deleteQuery.bindValue('spaces', $deleteQuerySpaces))
      #set ($docNamesToDelete = $deleteQuery.execute())
      #foreach ($docNameToDelete in $docNamesToDelete)
        #set ($docToDelete = $xwiki.getDocument($docNameToDelete))
        #set ($discard = $docToDelete.delete())
      #end
      ##
      ## If requested, redirect the UI after the work is complete.
      #if ($request.xredirect)
        $response.sendRedirect($request.xredirect)
      #end
    #else
      ## Confirmation dialog
      #set ($cancelURL = $doc.getURL())
      #if ($request.xredirect)
        #set ($redirectparam = "&amp;xredirect=$escapetool.url($request.xredirect)")
        #set ($cancelURL = $request.xredirect)
      #end
      #if ("$!scope" == 'entries')
        #set ($confirmationMessage = $services.localization.render('platform.appwithinminutes.deleteAppEntriesConfirmation', $escapetool.xml($appName)))
      #else
        #set ($confirmationMessage = $services.localization.render('platform.appwithinminutes.deleteAppConfirmation', $escapetool.xml($appName)))
      #end
      {{html}}
      #xwikimessagebox($services.localization.render('core.delete')
                      $confirmationMessage $doc.getURL($xcontext.action, "$request.queryString&confirm=1$!{redirectparam}&amp;form_token=$!{services.csrf.getToken()}")
                      $escapetool.xml($cancelURL)
                      $services.localization.render('yes')
                      $services.localization.render('no'))
      {{/html}}
    #end
  #else
    ## Unusable application name.
    #if (!$xwiki.exists($dataHomeRef))
      {{error}}$services.localization.render('platform.appwithinminutes.deleteAppDoesNotExistError'){{/error}}
    #else
      {{error}}$services.localization.render('platform.appwithinminutes.deleteAppInvalidAppError'){{/error}}
    #end
  #end
#else
  {{error}}$services.localization.render('platform.appwithinminutes.deleteAppNotSpecifiedError'){{/error}}
#end]
	at org.xwiki.rendering.internal.macro.velocity.VelocityMacro.evaluateString(VelocityMacro.java:131)
	at org.xwiki.rendering.internal.macro.velocity.VelocityMacro.evaluateString(VelocityMacro.java:50)
	at org.xwiki.rendering.macro.script.AbstractScriptMacro.evaluateBlock(AbstractScriptMacro.java:286)
	at org.xwiki.rendering.macro.script.AbstractScriptMacro.execute(AbstractScriptMacro.java:182)
	at org.xwiki.rendering.macro.script.AbstractScriptMacro.execute(AbstractScriptMacro.java:58)
	at org.xwiki.rendering.internal.transformation.macro.MacroTransformation.transform(MacroTransformation.java:251)
	at org.xwiki.rendering.internal.transformation.DefaultRenderingContext.transformInContext(DefaultRenderingContext.java:183)
	at org.xwiki.rendering.internal.transformation.DefaultTransformationManager.performTransformations(DefaultTransformationManager.java:94)
	at org.xwiki.display.internal.DocumentContentDisplayer.display(DocumentContentDisplayer.java:252)
	at org.xwiki.display.internal.DocumentContentDisplayer.display(DocumentContentDisplayer.java:125)
	at org.xwiki.display.internal.DocumentContentDisplayer.display(DocumentContentDisplayer.java:55)
	at org.xwiki.display.internal.DefaultDocumentDisplayer.display(DefaultDocumentDisplayer.java:96)
	at org.xwiki.display.internal.DefaultDocumentDisplayer.display(DefaultDocumentDisplayer.java:39)
	at org.xwiki.sheet.internal.SheetDocumentDisplayer.display(SheetDocumentDisplayer.java:113)
	at org.xwiki.sheet.internal.SheetDocumentDisplayer.display(SheetDocumentDisplayer.java:50)
	at org.xwiki.display.internal.ConfiguredDocumentDisplayer.display(ConfiguredDocumentDisplayer.java:67)
	at org.xwiki.display.internal.ConfiguredDocumentDisplayer.display(ConfiguredDocumentDisplayer.java:41)
	at com.xpn.xwiki.doc.XWikiDocument.getRenderedContent(XWikiDocument.java:1013)
	at com.xpn.xwiki.doc.XWikiDocument.getRenderedContent(XWikiDocument.java:991)
	at com.xpn.xwiki.doc.XWikiDocument.getRenderedContent(XWikiDocument.java:1023)
	at com.xpn.xwiki.api.Document.getRenderedContent(Document.java:606)
	at sun.reflect.GeneratedMethodAccessor857.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
	at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
	at org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
	at org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:71)
	at org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:142)
	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:106)
	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:228)
	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:187)
	at com.xpn.xwiki.render.XWikiVelocityRenderer.evaluate(XWikiVelocityRenderer.java:131)
	at com.xpn.xwiki.XWiki.parseTemplate(XWiki.java:1679)
	at com.xpn.xwiki.XWiki.evaluateTemplate(XWiki.java:1597)
	at com.xpn.xwiki.XWiki.parseTemplate(XWiki.java:1565)
	at com.xpn.xwiki.api.XWiki.parseTemplate(XWiki.java:801)
	at sun.reflect.GeneratedMethodAccessor731.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
	at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
	at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:369)
	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
	at org.apache.velocity.runtime.directive.VelocimacroProxy.render(VelocimacroProxy.java:216)
	at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:311)
	at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:230)
	at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:207)
	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:106)
	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:228)
	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:187)
	at com.xpn.xwiki.render.XWikiVelocityRenderer.evaluate(XWikiVelocityRenderer.java:131)
	at com.xpn.xwiki.XWiki.parseTemplate(XWiki.java:1679)
	at com.xpn.xwiki.XWiki.evaluateTemplate(XWiki.java:1597)
	at com.xpn.xwiki.web.Utils.parseTemplate(Utils.java:179)
	at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:358)
	at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:149)
	at org.apache.struts.action.RequestProcessor.processActionPerform(RequestProcessor.java:425)
	at org.apache.struts.action.RequestProcessor.process(RequestProcessor.java:228)
	at org.apache.struts.action.ActionServlet.process(ActionServlet.java:1913)
	at org.apache.struts.action.ActionServlet.doGet(ActionServlet.java:449)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:735)
	at javax.servlet.http.HttpServlet.service(HttpServlet.java:848)
	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:684)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1496)
	at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:115)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1484)
	at org.xwiki.wysiwyg.server.filter.ConversionFilter.doFilter(ConversionFilter.java:126)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1484)
	at com.xpn.xwiki.plugin.webdav.XWikiDavFilter.doFilter(XWikiDavFilter.java:66)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1484)
	at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:208)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1484)
	at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:111)
	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1476)
	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:501)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:137)
	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:557)
	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:231)
	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1086)
	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:429)
	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:193)
	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1020)
	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:135)
	at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:255)
	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:154)
	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:116)
	at org.eclipse.jetty.server.Server.handle(Server.java:370)
	at org.eclipse.jetty.server.AbstractHttpConnection.handleRequest(AbstractHttpConnection.java:494)
	at org.eclipse.jetty.server.AbstractHttpConnection.headerComplete(AbstractHttpConnection.java:971)
	at org.eclipse.jetty.server.AbstractHttpConnection$RequestHandler.headerComplete(AbstractHttpConnection.java:1033)
	at org.eclipse.jetty.http.HttpParser.parseNext(HttpParser.java:644)
	at org.eclipse.jetty.http.HttpParser.parseAvailable(HttpParser.java:235)
	at org.eclipse.jetty.server.AsyncHttpConnection.handle(AsyncHttpConnection.java:82)
	at org.eclipse.jetty.io.nio.SelectChannelEndPoint.handle(SelectChannelEndPoint.java:696)
	at org.eclipse.jetty.io.nio.SelectChannelEndPoint$1.run(SelectChannelEndPoint.java:53)
	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:608)
	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:543)
	at java.lang.Thread.run(Thread.java:745)
Caused by: org.xwiki.velocity.XWikiVelocityException: Failed to evaluate content with id [xwiki:AppWithinMinutes.DeleteApplication]
	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:247)
	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:187)
	at org.xwiki.rendering.internal.macro.velocity.VelocityMacro.evaluateString(VelocityMacro.java:124)
	... 110 more
Caused by: org.apache.velocity.exception.MethodInvocationException: Invocation of method 'execute' in  class org.xwiki.query.internal.ScriptQuery threw exception org.xwiki.query.QueryException: Exception while translating [FROM doc.object(my first appCode.myfirstappClass) as obj WHERE doc.space in (:spaces)] XWQL query to the [hql] language. Query statement = [FROM doc.object(my first appCode.myfirstappClass) as obj WHERE doc.space in (:spaces)] at xwiki:AppWithinMinutes.DeleteApplication[line 38, column 40]
	at org.apache.velocity.runtime.parser.node.ASTMethod.handleInvocationException(ASTMethod.java:243)
	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:187)
	at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:280)
	at org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:567)
	at org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:71)
	at org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:142)
	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
	at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:72)
	at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:87)
	at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:342)
	at org.xwiki.velocity.internal.DefaultVelocityEngine.evaluate(DefaultVelocityEngine.java:228)
	... 112 more
Caused by: org.xwiki.query.QueryException: Exception while translating [FROM doc.object(my first appCode.myfirstappClass) as obj WHERE doc.space in (:spaces)] XWQL query to the [hql] language. Query statement = [FROM doc.object(my first appCode.myfirstappClass) as obj WHERE doc.space in (:spaces)]
	at org.xwiki.query.xwql.internal.XWQLQueryExecutor.execute(XWQLQueryExecutor.java:102)
	at org.xwiki.query.internal.DefaultQueryExecutorManager.execute(DefaultQueryExecutorManager.java:71)
	at org.xwiki.query.internal.SecureQueryExecutorManager.execute(SecureQueryExecutorManager.java:90)
	at org.xwiki.query.internal.DefaultQuery.execute(DefaultQuery.java:248)
	at org.xwiki.query.internal.ScriptQuery.execute(ScriptQuery.java:236)
	at sun.reflect.GeneratedMethodAccessor839.invoke(Unknown Source)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:395)
	at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:384)
	at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:173)
	... 124 more
Caused by: org.xwiki.query.jpql.parser.ParserException: [1,58] expecting: ')'
	at org.xwiki.query.jpql.parser.Parser.parse(Parser.java:1385)
	at org.xwiki.query.jpql.internal.JPQLParser.parse(JPQLParser.java:46)
	at org.xwiki.query.xwql.internal.hql.XWQLtoHQLTranslator.translate(XWQLtoHQLTranslator.java:55)
	at org.xwiki.query.xwql.internal.XWQLQueryExecutor.execute(XWQLQueryExecutor.java:79)
	... 134 more

Doesn't reproduce if instead of "my first app" you pick a name like "myfirstapp".

Attachments

Issue Links

is related to

XWIKI-11237 Cannot create an application with ^ in the name

Closed

XWIKI-11238 Space name cleanup: not for the data space, but only for the code space

Closed

Unable to "Delete all entries" from apps whose names include a space

Details

Description

Attachments

Issue Links

Activity

People

Dates