Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-11086

Test framework may fail to wait properly for XWiki to start when an existing instance is running

    Details

    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Similar issues:

      Description

      For example this is what Eduard got when testing locally:

      -------------------------------------------------------
       T E S T S
      -------------------------------------------------------
      Running org.xwiki.test.ui.AllTests
      17:23:27.871 [main] INFO  o.x.test.integration.XWikiExecutor - Starting XWiki server at [http://localhost:8080/xwiki/bin/get/Main/]
      17:23:28.006 [main] INFO  o.x.test.integration.XWikiExecutor - Checking that XWiki is up and running...
      17:23:28.148 [Thread-1] INFO  o.x.t.i.XWikiLogOutputStream - An XWiki instance is already running on port 8080, stopping it!
      17:23:28.150 [Thread-1] INFO  o.x.t.i.XWikiLogOutputStream - Attempting to stop XWiki cleanly on port 8080...
      17:23:28.727 [main] INFO  o.x.test.integration.XWikiExecutor - Server is answering to [http://localhost:8080/xwiki/bin/get/Main/]... cool
      17:23:40.186 [Thread-1] INFO  o.x.t.i.XWikiLogOutputStream - Starting Jetty on port 8080, please wait...
      

      What happens is that:

      • An instance is running
      • XWikiExecutor runs start_xwiki.sh on a separate thread
      • XWikiExecutor then waits by pinging XWiki
      • Even though start_xwiki.sh notices that an existing instance is running and start to stop it, XWikiExecutor still get its ping answered by the existing instance and thus continues even though the existing instance has not finished stopping and the new instance is not fully started yet.

        Attachments

          Activity

            People

            • Assignee:
              vmassol Vincent Massol
              Reporter:
              vmassol Vincent Massol
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: