XWiki Platform
  1. XWiki Platform
  2. XWIKI-13274

Subpages don't inherit properly space rating configuration

    Details

    • Tests:
      Unit
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      At this moment the ratings can be configured at space level in WebPreferences document of that space.
      A.B.C.WebHome will check if in A.B.C.WebPreferences exists a XWiki.RatingsConfigClass object and if not, then jumps to XWiki.RatingsConfig document to get configuration from there.
      Instead, it should look in A.B.C.WebPreferences, A.B.WebPreferences and A.WebPreferences before the fallback to XWiki.RatingsConfigdocument.

        Issue Links

          Activity

          Show
          Alex Cotiugă added a comment - PR: https://github.com/xwiki/xwiki-platform/pull/472
          Hide
          Alex Cotiugă added a comment -

          Created PR 528.

          Show
          Alex Cotiugă added a comment - Created PR 528 .
          Hide
          Thomas Mortagne added a comment - - edited

          Reopenning because it seems to be causing

          20:52:13.952  - java.lang.NullPointerException
          20:52:13.952  - 	at org.xwiki.ratings.internal.AbstractRatingsManager.isAverageRatingStored(AbstractRatingsManager.java:115)
          20:52:13.952  - 	at org.xwiki.ratings.internal.AbstractRatingsManager.getAverageRating(AbstractRatingsManager.java:303)
          20:52:13.952  - 	at org.xwiki.ratings.internal.AbstractRatingsManager.getAverageRating(AbstractRatingsManager.java:295)
          20:52:13.952  - 	at org.xwiki.ratings.internal.AbstractRatingsManager.getAverageRating(AbstractRatingsManager.java:165)
          20:52:13.952  - 	at org.xwiki.repository.internal.resources.AbstractExtensionRESTResource.getExtensionRating(AbstractExtensionRESTResource.java:756)
          20:52:13.952  - 	at org.xwiki.repository.internal.resources.AbstractExtensionRESTResource.createExtension(AbstractExtensionRESTResource.java:331)
          20:52:13.952  - 	at org.xwiki.repository.internal.resources.ExtensionVersionRESTResource.getExtensionVersion(ExtensionVersionRESTResource.java:55)
          20:52:13.952  - 	at sun.reflect.GeneratedMethodAccessor505.invoke(Unknown Source)
          20:52:13.952  - 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
          20:52:13.952  - 	at java.lang.reflect.Method.invoke(Method.java:497)
          20:52:13.952  - 	at org.restlet.ext.jaxrs.internal.wrappers.AbstractMethodWrapper.internalInvoke(AbstractMethodWrapper.java:171)
          20:52:13.952  - 	at org.restlet.ext.jaxrs.internal.wrappers.ResourceMethod.invoke(ResourceMethod.java:291)
          20:52:13.952  - 	at org.restlet.ext.jaxrs.JaxRsRestlet.invokeMethod(JaxRsRestlet.java:1043)
          20:52:13.952  - 	at org.restlet.ext.jaxrs.JaxRsRestlet.handle(JaxRsRestlet.java:792)
          20:52:13.952  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Router.doHandle(Router.java:500)
          20:52:13.953  - 	at org.restlet.routing.Router.handle(Router.java:740)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.engine.application.StatusFilter.doHandle(StatusFilter.java:154)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.engine.ChainHelper.handle(ChainHelper.java:114)
          20:52:13.953  - 	at org.restlet.engine.application.ApplicationHelper.handle(ApplicationHelper.java:75)
          20:52:13.953  - 	at org.restlet.Application.handle(Application.java:391)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Router.doHandle(Router.java:500)
          20:52:13.953  - 	at org.restlet.routing.Router.handle(Router.java:740)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.routing.Router.doHandle(Router.java:500)
          20:52:13.953  - 	at org.restlet.routing.Router.handle(Router.java:740)
          20:52:13.953  - 	at org.restlet.routing.Filter.doHandle(Filter.java:159)
          20:52:13.953  - 	at org.restlet.routing.Filter.handle(Filter.java:206)
          20:52:13.953  - 	at org.restlet.engine.ChainHelper.handle(ChainHelper.java:114)
          20:52:13.953  - 	at org.restlet.Component.handle(Component.java:391)
          20:52:13.953  - 	at org.restlet.Server.handle(Server.java:491)
          20:52:13.953  - 	at org.restlet.engine.ServerHelper.handle(ServerHelper.java:74)
          20:52:13.953  - 	at org.restlet.engine.http.HttpServerHelper.handle(HttpServerHelper.java:153)
          20:52:13.953  - 	at org.restlet.ext.servlet.ServerServlet.service(ServerServlet.java:1031)
          20:52:13.953  - 	at javax.servlet.http.HttpServlet.service(HttpServlet.java:790)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:808)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669)
          20:52:13.953  - 	at org.xwiki.wysiwyg.server.filter.XWikiContextInitializationFilter.doFilter(XWikiContextInitializationFilter.java:85)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
          20:52:13.953  - 	at org.xwiki.container.servlet.filters.internal.SetHTTPHeaderFilter.doFilter(SetHTTPHeaderFilter.java:63)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
          20:52:13.953  - 	at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:208)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
          20:52:13.953  - 	at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:111)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
          20:52:13.953  - 	at org.xwiki.resource.servlet.RoutingFilter.doFilter(RoutingFilter.java:137)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585)
          20:52:13.953  - 	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143)
          20:52:13.953  - 	at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577)
          20:52:13.953  - 	at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223)
          20:52:13.953  - 	at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127)
          20:52:13.953  - 	at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515)
          20:52:13.953  - 	at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185)
          20:52:13.953  - 	at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061)
          20:52:13.953  - 	at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141)
          20:52:13.953  - 	at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215)
          20:52:13.953  - 	at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110)
          20:52:13.953  - 	at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97)
          20:52:13.953  - 	at org.eclipse.jetty.server.Server.handle(Server.java:499)
          20:52:13.953  - 	at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310)
          20:52:13.953  - 	at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257)
          20:52:13.953  - 	at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540)
          20:52:13.953  - 	at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635)
          20:52:13.953  - 	at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555)
          20:52:13.953  - 	at java.lang.Thread.run(Thread.java:745)
          
          Show
          Thomas Mortagne added a comment - - edited Reopenning because it seems to be causing 20:52:13.952 - java.lang.NullPointerException 20:52:13.952 - at org.xwiki.ratings.internal.AbstractRatingsManager.isAverageRatingStored(AbstractRatingsManager.java:115) 20:52:13.952 - at org.xwiki.ratings.internal.AbstractRatingsManager.getAverageRating(AbstractRatingsManager.java:303) 20:52:13.952 - at org.xwiki.ratings.internal.AbstractRatingsManager.getAverageRating(AbstractRatingsManager.java:295) 20:52:13.952 - at org.xwiki.ratings.internal.AbstractRatingsManager.getAverageRating(AbstractRatingsManager.java:165) 20:52:13.952 - at org.xwiki.repository.internal.resources.AbstractExtensionRESTResource.getExtensionRating(AbstractExtensionRESTResource.java:756) 20:52:13.952 - at org.xwiki.repository.internal.resources.AbstractExtensionRESTResource.createExtension(AbstractExtensionRESTResource.java:331) 20:52:13.952 - at org.xwiki.repository.internal.resources.ExtensionVersionRESTResource.getExtensionVersion(ExtensionVersionRESTResource.java:55) 20:52:13.952 - at sun.reflect.GeneratedMethodAccessor505.invoke(Unknown Source) 20:52:13.952 - at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) 20:52:13.952 - at java.lang.reflect.Method.invoke(Method.java:497) 20:52:13.952 - at org.restlet.ext.jaxrs.internal.wrappers.AbstractMethodWrapper.internalInvoke(AbstractMethodWrapper.java:171) 20:52:13.952 - at org.restlet.ext.jaxrs.internal.wrappers.ResourceMethod.invoke(ResourceMethod.java:291) 20:52:13.952 - at org.restlet.ext.jaxrs.JaxRsRestlet.invokeMethod(JaxRsRestlet.java:1043) 20:52:13.952 - at org.restlet.ext.jaxrs.JaxRsRestlet.handle(JaxRsRestlet.java:792) 20:52:13.952 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Router.doHandle(Router.java:500) 20:52:13.953 - at org.restlet.routing.Router.handle(Router.java:740) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.engine.application.StatusFilter.doHandle(StatusFilter.java:154) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.engine.ChainHelper.handle(ChainHelper.java:114) 20:52:13.953 - at org.restlet.engine.application.ApplicationHelper.handle(ApplicationHelper.java:75) 20:52:13.953 - at org.restlet.Application.handle(Application.java:391) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Router.doHandle(Router.java:500) 20:52:13.953 - at org.restlet.routing.Router.handle(Router.java:740) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.routing.Router.doHandle(Router.java:500) 20:52:13.953 - at org.restlet.routing.Router.handle(Router.java:740) 20:52:13.953 - at org.restlet.routing.Filter.doHandle(Filter.java:159) 20:52:13.953 - at org.restlet.routing.Filter.handle(Filter.java:206) 20:52:13.953 - at org.restlet.engine.ChainHelper.handle(ChainHelper.java:114) 20:52:13.953 - at org.restlet.Component.handle(Component.java:391) 20:52:13.953 - at org.restlet.Server.handle(Server.java:491) 20:52:13.953 - at org.restlet.engine.ServerHelper.handle(ServerHelper.java:74) 20:52:13.953 - at org.restlet.engine.http.HttpServerHelper.handle(HttpServerHelper.java:153) 20:52:13.953 - at org.restlet.ext.servlet.ServerServlet.service(ServerServlet.java:1031) 20:52:13.953 - at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:808) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1669) 20:52:13.953 - at org.xwiki.wysiwyg.server.filter.XWikiContextInitializationFilter.doFilter(XWikiContextInitializationFilter.java:85) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) 20:52:13.953 - at org.xwiki.container.servlet.filters.internal.SetHTTPHeaderFilter.doFilter(SetHTTPHeaderFilter.java:63) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) 20:52:13.953 - at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:208) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) 20:52:13.953 - at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:111) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) 20:52:13.953 - at org.xwiki.resource.servlet.RoutingFilter.doFilter(RoutingFilter.java:137) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1652) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:585) 20:52:13.953 - at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) 20:52:13.953 - at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:577) 20:52:13.953 - at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:223) 20:52:13.953 - at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1127) 20:52:13.953 - at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:515) 20:52:13.953 - at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:185) 20:52:13.953 - at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1061) 20:52:13.953 - at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) 20:52:13.953 - at org.eclipse.jetty.server.handler.ContextHandlerCollection.handle(ContextHandlerCollection.java:215) 20:52:13.953 - at org.eclipse.jetty.server.handler.HandlerCollection.handle(HandlerCollection.java:110) 20:52:13.953 - at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:97) 20:52:13.953 - at org.eclipse.jetty.server.Server.handle(Server.java:499) 20:52:13.953 - at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:310) 20:52:13.953 - at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:257) 20:52:13.953 - at org.eclipse.jetty.io.AbstractConnection$2.run(AbstractConnection.java:540) 20:52:13.953 - at org.eclipse.jetty.util.thread.QueuedThreadPool.runJob(QueuedThreadPool.java:635) 20:52:13.953 - at org.eclipse.jetty.util.thread.QueuedThreadPool$3.run(QueuedThreadPool.java:555) 20:52:13.953 - at java.lang. Thread .run( Thread .java:745)

            People

            • Assignee:
              Alex Cotiugă
              Reporter:
              Alex Cotiugă
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Date of First Response: