Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-14132

Menu burgers don't expand when clicked on mobile

Details

    • Bug
    • Resolution: Cannot Reproduce
    • Major
    • None
    • 9.2-rc-1
    • Menu
    • Unknown

    Description

      This bug is related to the fix for XWIKI-13636.
      On mobile, when I clicked on the new burger menu nothing happened.

      I've reproduced the bug on all browsers: IE11, Edge 38, Firefox 52 and Chrome 57.

      Attachments

        Issue Links

          Activity

            [XWIKI-14132] Menu burgers don't expand when clicked on mobile

            Cannot reproduce anymore (tested on 16.1.0).

            tmortagne Thomas Mortagne added a comment - Cannot reproduce anymore (tested on 16.1.0).

            As aifrim noticed, the issue is that the data-target attribute is not set, and that is because the id attribute of the menu macro is not specified. ATM the id attribute is documented as optional. Either we generate an id if it's not specified or we make the id parameter mandatory. The first option is the best I think.

            mflorea Marius Dumitru Florea added a comment - As aifrim noticed, the issue is that the data-target attribute is not set, and that is because the id attribute of the menu macro is not specified. ATM the id attribute is documented as optional. Either we generate an id if it's not specified or we make the id parameter mandatory. The first option is the best I think.

            People

              tmortagne Thomas Mortagne
              msmeria Manuel Smeria
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: