Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-18709

Annotations can be displayed when editing a page in place and annotation markup is saved in the page content in that case



    • Integration
    • Unknown
    • N/A
    • N/A


      How to reproduce:

      1. create a document
      2. add 2 annotations on that document, from view mode
      3. refresh the page (so that annotations view dissapears and the page displays clean as when you enter the page)
      4. click "Edit" (Modifier in my french screenshot) to enter in-place edit mode:
      5. at this point, go in the kebab menu, click annotations and then in the subsequently displayed panel, check "show annotations"
      6. the annotations will be displayed in the content that is edited in-place
      7. click save and close (Enregistrer & fermer in my french screenshots)

      Actual results:

      • yellow areas are now displayed in view mode of the page, even when annotations are not displayed:
      • the html used for displaying annotations in view mode is now saved in the page content:

      Expected results:
      Globally, the objective is to never save annotations markup in the page content.
      In detail, as for the other edit modes, I would expect this to be achieved by not being able to use annotations at all when editing in place.

      Variation 1: at step 5 in the list of steps above, instead of displaying annotations from the menu, select a piece of text and then hit the Ctrl + M shortcut: the UI to add an annotation will be displayed. Add an annotation with this UI. After the annotation add, all other annotations available on the document will be displayed. This happens and annotations markup is also saved when this happens.

      Variation 2: I haven't yet checked what happens when the annotations are configured to be always loaded on the pages, this may also happen.


        Issue Links



              mflorea Marius Dumitru Florea
              lucaa Anca Luca
              0 Vote for this issue
              3 Start watching this issue