Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-19567

Left Top Menu UIXP order is reversed by the flamingo skin

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 7.1
    • Fix Version/s: 14.2, 13.10.4
    • Component/s: Flamingo Skin
    • Labels:
      None
    • Difficulty:
      Unknown
    • Documentation:
      N/A
    • Documentation in Release Notes:
      N/A
    • Similar issues:

      Description

      Ever since the left top menu UIXP was introduced, it featured an order which is documented as:

      the order in which the item will be displayed. The lower the number is, the more on the left the item is.

      https://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/ExtensionPoint/TopMenuLeft

      However, at the skin level, all top menu items (.navbar-nav > li) are floated right. That fits well the ordering logic of the right top menu, which is reversed:

        The lower the number is, the more on the right the item is.

      https://www.xwiki.org/xwiki/bin/view/Documentation/DevGuide/ExtensionPoint/TopMenuRight

      However, for the left top menu UIXP, it ends up reversing the documented and originally intended order.

      So 3 UIX for org.xwiki.platform.topmenu.left using the orders "1, 2, 3", even if retrieved and handled correctly by the UIXP will be displayed as "3, 2, 1" because of the skin's bad CSS which did not consider the 2 types of top menus (navbar-left and navbar-right) and treating all items as part of a single, right floated, top menu.

      The less/cass code in issue is at:
      https://github.com/xwiki/xwiki-platform/blob/1693a6f/xwiki-platform-core/xwiki-platform-flamingo/xwiki-platform-flamingo-skin/xwiki-platform-flamingo-skin-resources/src/main/resources/flamingo/less/action-menus.less#L5-L45

        Attachments

          Activity

            People

            Assignee:
            enygma Eduard Moraru
            Reporter:
            enygma Eduard Moraru
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: