Uploaded image for project: 'XWiki Platform'
  1. XWiki Platform
  2. XWIKI-23113

Abusive modification of the cached document when adding a comment on a page

    XMLWordPrintable

Details

    • Bug
    • Resolution: Solved By
    • Major
    • 17.3.0-rc-1
    • 17.2.1
    • None
    • Windows 11 Pro, Edge 135, using an instance of XWiki 17.2.1 on Oracle 19c, Tomcat 11.0.5, reproducible also on Jetty/HSQL demo
    • Unknown
    • N/A
    • N/A

    Description

      Steps to reproduce

      1. Add a comment to a page
      2. Observe the logs

      Expected results

      No warnings are displayed.

      Actual results

      The following warning is displayed in the logs:

      2025-04-15 18:01:53,209 [http-nio-1115-exec-9 - http://localhost:1115/xwiki/bin/get/Main/?xpage=xpart&vm=commentfield.vm&number=&name=XWiki.XWikiComments_comment] WARN  c.x.x.d.XWikiDocument          - Abusive modification of the cached document [xwiki:XWiki.XWikiComments()]
      java.lang.IllegalStateException: Abusive modification of the cached document
              at com.xpn.xwiki.doc.XWikiDocument.setMetaDataDirty(XWikiDocument.java:2457)
              at com.xpn.xwiki.objects.BaseElement.setOwnerDocument(BaseElement.java:522)
              at com.xpn.xwiki.objects.BaseCollection.setOwnerDocument(BaseCollection.java:994)
              at com.xpn.xwiki.objects.BaseCollection.addField(BaseCollection.java:546)
              at com.xpn.xwiki.objects.classes.BaseClass.addField(BaseClass.java:196)
              at com.xpn.xwiki.objects.BaseCollection.safeput(BaseCollection.java:272)
              at com.xpn.xwiki.objects.classes.BaseClass.put(BaseClass.java:248)
              at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
              at java.base/java.lang.reflect.Method.invoke(Method.java:580)
              at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:571)
              at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:554)
              at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:221)
              at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:368)
              at org.apache.velocity.runtime.parser.node.ASTReference.value(ASTReference.java:704)
              at org.apache.velocity.runtime.parser.node.ASTExpression.value(ASTExpression.java:75)
              at org.apache.velocity.runtime.parser.node.ASTSetDirective.render(ASTSetDirective.java:242)
              at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:147)
              at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:171)
              at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:439)
              at org.apache.velocity.Template.merge(Template.java:358)
              at org.apache.velocity.Template.merge(Template.java:262)
              at org.xwiki.velocity.internal.InternalVelocityEngine.evaluate(InternalVelocityEngine.java:233)
              at com.xpn.xwiki.internal.template.VelocityTemplateEvaluator.evaluateContent(VelocityTemplateEvaluator.java:107)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.evaluateContent(TemplateAsyncRenderer.java:219)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.renderVelocity(TemplateAsyncRenderer.java:174)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.render(TemplateAsyncRenderer.java:135)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.render(TemplateAsyncRenderer.java:54)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.lambda$syncRender$0(DefaultAsyncRendererExecutor.java:284)
              at com.xpn.xwiki.internal.security.authorization.DefaultAuthorExecutor.call(DefaultAuthorExecutor.java:98)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.syncRender(DefaultAsyncRendererExecutor.java:284)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.render(DefaultAsyncRendererExecutor.java:267)
              at org.xwiki.rendering.async.internal.block.DefaultBlockAsyncRendererExecutor.render(DefaultBlockAsyncRendererExecutor.java:154)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:904)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:866)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:853)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.renderNoException(InternalTemplateManager.java:808)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.renderNoException(InternalTemplateManager.java:800)
              at com.xpn.xwiki.internal.template.DefaultTemplateManager.renderNoException(DefaultTemplateManager.java:79)
              at com.xpn.xwiki.internal.template.DefaultTemplateManager.renderNoException(DefaultTemplateManager.java:73)
              at org.xwiki.template.script.TemplateScriptService.render(TemplateScriptService.java:54)
              at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
              at java.base/java.lang.reflect.Method.invoke(Method.java:580)
              at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.doInvoke(UberspectImpl.java:571)
              at org.apache.velocity.util.introspection.UberspectImpl$VelMethodImpl.invoke(UberspectImpl.java:554)
              at org.apache.velocity.runtime.parser.node.ASTMethod.execute(ASTMethod.java:221)
              at org.apache.velocity.runtime.parser.node.ASTReference.execute(ASTReference.java:368)
              at org.apache.velocity.runtime.parser.node.ASTReference.render(ASTReference.java:492)
              at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:147)
              at org.apache.velocity.runtime.directive.VelocimacroProxy.render(VelocimacroProxy.java:217)
              at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:331)
              at org.apache.velocity.runtime.directive.RuntimeMacro.render(RuntimeMacro.java:261)
              at org.apache.velocity.runtime.parser.node.ASTDirective.render(ASTDirective.java:304)
              at org.apache.velocity.runtime.parser.node.ASTBlock.render(ASTBlock.java:147)
              at org.apache.velocity.runtime.parser.node.ASTIfStatement.render(ASTIfStatement.java:171)
              at org.apache.velocity.runtime.parser.node.SimpleNode.render(SimpleNode.java:439)
              at org.apache.velocity.Template.merge(Template.java:358)
              at org.apache.velocity.Template.merge(Template.java:262)
              at org.xwiki.velocity.internal.InternalVelocityEngine.evaluate(InternalVelocityEngine.java:233)
              at com.xpn.xwiki.internal.template.VelocityTemplateEvaluator.evaluateContent(VelocityTemplateEvaluator.java:107)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.evaluateContent(TemplateAsyncRenderer.java:219)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.renderVelocity(TemplateAsyncRenderer.java:174)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.render(TemplateAsyncRenderer.java:135)
              at com.xpn.xwiki.internal.template.TemplateAsyncRenderer.render(TemplateAsyncRenderer.java:54)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.lambda$syncRender$0(DefaultAsyncRendererExecutor.java:284)
              at com.xpn.xwiki.internal.security.authorization.DefaultAuthorExecutor.call(DefaultAuthorExecutor.java:98)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.syncRender(DefaultAsyncRendererExecutor.java:284)
              at org.xwiki.rendering.async.internal.DefaultAsyncRendererExecutor.render(DefaultAsyncRendererExecutor.java:267)
              at org.xwiki.rendering.async.internal.block.DefaultBlockAsyncRendererExecutor.render(DefaultBlockAsyncRendererExecutor.java:154)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:904)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:866)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.renderFromSkin(InternalTemplateManager.java:846)
              at com.xpn.xwiki.internal.template.InternalTemplateManager.render(InternalTemplateManager.java:832)
              at com.xpn.xwiki.internal.template.DefaultTemplateManager.render(DefaultTemplateManager.java:91)
              at com.xpn.xwiki.internal.template.DefaultTemplateManager.render(DefaultTemplateManager.java:85)
              at com.xpn.xwiki.XWiki.evaluateTemplate(XWiki.java:2570)
              at com.xpn.xwiki.web.Utils.parseTemplate(Utils.java:180)
              at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:650)
              at com.xpn.xwiki.web.XWikiAction.execute(XWikiAction.java:338)
              at com.xpn.xwiki.web.LegacyActionServlet.service(LegacyActionServlet.java:111)
              at jakarta.servlet.http.HttpServlet.service(HttpServlet.java:716)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:130)
              at com.xpn.xwiki.web.ActionFilter.doFilter(ActionFilter.java:123)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.wysiwyg.filter.ConversionFilter.doFilter(ConversionFilter.java:65)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:51)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SetHTTPHeaderFilter.doFilter(SetHTTPHeaderFilter.java:66)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.resource.servlet.RoutingFilter.doFilter(RoutingFilter.java:135)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SavedRequestRestorerFilter.doFilter(SavedRequestRestorerFilter.java:211)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SafeRedirectFilter.doFilter(SafeRedirectFilter.java:106)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.ResolveRelativeRedirectFilter.doFilter(ResolveRelativeRedirectFilter.java:129)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.xwiki.container.servlet.filters.internal.SetCharacterEncodingFilter.doFilter(SetCharacterEncodingFilter.java:120)
              at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:109)
              at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:167)
              at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:79)
              at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:483)
              at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:115)
              at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:93)
              at org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:670)
              at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:74)
              at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:342)
              at org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:395)
              at org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
              at org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:905)
              at org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1748)
              at org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
              at org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1148)
              at org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
              at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:63)
              at java.base/java.lang.Thread.run(Thread.java:1583)

       

      Attachments

        Issue Links

          Activity

            People

              tmortagne Thomas Mortagne
              iandriuta Ilie Andriuta
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: